Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: bluetooth: distance measurement multiantenna improvements #20984

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

ivaniushkov
Copy link
Contributor

added better handling of multiple antenna path in Channel Sounding Initiator distance estimation algorithm.
Now distance is calculated and printed separately
for each antenna path

@ivaniushkov ivaniushkov requested a review from a team as a code owner March 18, 2025 07:16
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Mar 18, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Mar 18, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 4

Inputs:

Sources:

sdk-nrf: PR head: 6acb7075c921cf6d74d3ad93117245e0f0a90563

more details

sdk-nrf:

PR head: 6acb7075c921cf6d74d3ad93117245e0f0a90563
merge base: 76259e03400cf80ff7da36698ffe44bdde1928ac
target head (main): 0d6ecb989bf889e36fc37acb7eed9ac76ea75bca
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (2)
samples
│  ├── bluetooth
│  │  ├── channel_sounding_ras_initiator
│  │  │  ├── README.rst
│  │  │  ├── src
│  │  │  │  │ distance_estimation.c

Outputs:

Toolchain

Version: 4ffa2202d5
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:4ffa2202d5_e579f9fbe6

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 470
  • ✅ Integration tests
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@ivaniushkov ivaniushkov force-pushed the multiantenna_improvements branch from b75f85e to ad5e1e3 Compare March 18, 2025 07:38
@ivaniushkov ivaniushkov requested a review from a team as a code owner March 18, 2025 07:38
@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label Mar 18, 2025
@olivier-le-sage olivier-le-sage self-requested a review March 18, 2025 07:40
Copy link

You can find the documentation preview for this PR here.

Preview links for modified nRF Connect SDK documents:

https://ncsdoc.z6.web.core.windows.net/PR-20984/nrf/samples/bluetooth/channel_sounding_ras_initiator/README.html

@thomas-m-johansen thomas-m-johansen self-requested a review March 18, 2025 09:18
@ivaniushkov ivaniushkov force-pushed the multiantenna_improvements branch from ad5e1e3 to 9da4622 Compare March 18, 2025 09:20
added better handling of multiple antenna path in Channel Sounding
Initiator distance estimation algorithm.
Now distance is calculated and printed separately
for each antenna path

Signed-off-by: Ivan Iushkov <ivan.iushkov@nordicsemi.no>
@ivaniushkov ivaniushkov removed doc-required PR must not be merged without tech writer approval. changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Mar 18, 2025
Copy link
Contributor

@olivier-le-sage olivier-le-sage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it locally, seems to work nicely.

I expect the sample test to still pass even with the changes to the log messages, but would be good to check before merging

@ivaniushkov ivaniushkov added the doc-required PR must not be merged without tech writer approval. label Mar 19, 2025
@ivaniushkov ivaniushkov requested a review from richabp March 19, 2025 13:45
@nordicjm nordicjm merged commit 26355ee into nrfconnect:main Mar 21, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants