samples: Add nRF2220EK support for RT and DTM samples #21027

dchat-nordic · 2025-03-19T10:47:29Z

Add nRF2220EK support for:

direct_test_mode
radio_test samples.

Jira: NCSDK-31910

NordicBuilder · 2025-03-19T10:51:13Z

CI Information

^{To view the history of this post, clich the 'edited' button above}
Build number: 7

Inputs:

Sources:

sdk-nrf: PR head: c5709d287ac4d6528b431306124f952ddeb6b6e8

more details

sdk-nrf:

PR head: c5709d287ac4d6528b431306124f952ddeb6b6e8
merge base: e2245b18abbb77413b95fe5a27b336fb98a3a275
target head (main): 0b0505af66b488d263f472b2eec6283a7201abed
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (6)

doc
│  ├── nrf
│  │  ├── includes
│  │  │  │ sample_dtm_radio_test_fem.txt
│  │  ├── releases_and_maturity
│  │  │  ├── releases
│  │  │  │  │ release-notes-changelog.rst
samples
│  ├── bluetooth
│  │  ├── direct_test_mode
│  │  │  ├── README.rst
│  │  │  │ sample.yaml
│  ├── peripheral
│  │  ├── radio_test
│  │  │  ├── README.rst
│  │  │  │ sample.yaml

Outputs:

Toolchain

Version: 4ffa2202d5
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:4ffa2202d5_8bf7ca4353

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain - Skipped: existing toolchain is used
✅ Build twister
- sdk-nrf test count: 485
✅ Integration tests
- ✅ test-fw-nrfconnect-ble_samples

Disabled integration tests

- desktop52_verification
- doc-internal
- test-fw-nrfconnect-apps
- test-fw-nrfconnect-ble_mesh
- test-fw-nrfconnect-boot
- test-fw-nrfconnect-chip
- test-fw-nrfconnect-fem
- test-fw-nrfconnect-nfc
- test-fw-nrfconnect-nrf-iot_cloud
- test-fw-nrfconnect-nrf-iot_libmodem-nrf
- test-fw-nrfconnect-nrf-iot_mosh
- test-fw-nrfconnect-nrf-iot_positioning
- test-fw-nrfconnect-nrf-iot_samples
- test-fw-nrfconnect-nrf-iot_serial_lte_modem
- test-fw-nrfconnect-nrf-iot_thingy91
- test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
- test-fw-nrfconnect-nrf_crypto
- test-fw-nrfconnect-proprietary_esb
- test-fw-nrfconnect-ps
- test-fw-nrfconnect-rpc
- test-fw-nrfconnect-rs
- test-fw-nrfconnect-tfm
- test-fw-nrfconnect-thread
- test-low-level
- test-sdk-audio
- test-sdk-dfu
- test-sdk-find-my
- test-sdk-mcuboot
- test-sdk-pmic-samples
- test-sdk-wifi
- test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

sonarqubecloud · 2025-03-19T10:53:17Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2025-03-19T11:06:55Z

You can find the documentation preview for this PR here.

Preview links for modified nRF Connect SDK documents:

https://ncsdoc.z6.web.core.windows.net/PR-21027/nrf/releases_and_maturity/releases/release-notes-changelog.html
https://ncsdoc.z6.web.core.windows.net/PR-21027/nrf/samples/bluetooth/direct_test_mode/README.html
https://ncsdoc.z6.web.core.windows.net/PR-21027/nrf/samples/peripheral/radio_test/README.html

peknis · 2025-03-19T10:58:08Z

doc/nrf/includes/sample_dtm_radio_test_fem.txt


-To add support for the nRF21540 FEM, build the sample for a board containing nRF21540 FEM like :ref:`nrf21540dk/nrf52840 <zephyr:nrf21540dk_nrf52840>` or create a devicetree overlay file describing how FEM is connected to nRF5 SoC in your device.
+To add support for the FEM, build the sample for a board containing FEM like :ref:`nrf21540dk/nrf52840 <zephyr:nrf21540dk_nrf52840>` or create a devicetree overlay file describing how FEM is connected to nRF5 SoC in your device.


Suggested change

To add support for the FEM, build the sample for a board containing FEM like :ref:`nrf21540dk/nrf52840 <zephyr:nrf21540dk_nrf52840>` or create a devicetree overlay file describing how FEM is connected to nRF5 SoC in your device.

To add support for the FEM, build the sample for a board containing FEM like :ref:`nRF21540 DK/nRF52840 <zephyr:nrf21540dk_nrf52840>` or create a devicetree overlay file describing how FEM is connected to the nRF52 Series SoC in your device.

peknis · 2025-03-19T10:58:47Z

doc/nrf/includes/sample_dtm_radio_test_fem.txt


 .. note::
   If you use the nRF21540 EK, append ``nrf21540ek`` shield to your build command instructing build system to append the appropriate devicetree overlay file.
+   If you use the nRF2220EK, append ``nrf2220ek`` shield to your build command instructing build system to append the appropriate devicetree overlay file.


Suggested change

If you use the nRF2220EK, append ``nrf2220ek`` shield to your build command instructing build system to append the appropriate devicetree overlay file.

If you use the nRF2220 EK, append the ``nrf2220ek`` shield to your build command instructing the build system to append the appropriate devicetree overlay file.

peknis · 2025-03-19T11:10:38Z

samples/bluetooth/direct_test_mode/README.rst


 .. include:: /includes/sample_dtm_radio_test_fem.txt

-You can configure the transmitted power gain, antenna output and activation delay in nRF21540 using vendor-specific commands, see `Vendor-specific packet payload`_.
+You can configure the transmitted power gain, antenna output and activation delay in FEMs using vendor-specific commands, see `Vendor-specific packet payload`_.


Suggested change

You can configure the transmitted power gain, antenna output and activation delay in FEMs using vendor-specific commands, see `Vendor-specific packet payload`_.

You can configure the transmitted power gain, antenna output, and activation delay in FEMs using vendor-specific commands, see `Vendor-specific packet payload`_.

peknis · 2025-03-19T11:10:59Z

samples/peripheral/radio_test/README.rst


 .. include:: /includes/sample_dtm_radio_test_fem.txt

-You can configure the nRF21540 front-end module (FEM) transmitted power control, antenna output and activation delay using the main shell commands of the :ref:`radio_test_ui`.
+You can configure the front-end module (FEM) transmitted power control, antenna output and activation delay using the main shell commands of the :ref:`radio_test_ui`.


Suggested change

You can configure the front-end module (FEM) transmitted power control, antenna output and activation delay using the main shell commands of the :ref:`radio_test_ui`.

You can configure the front-end module (FEM) transmitted power control, antenna output, and activation delay using the main shell commands of the :ref:`radio_test_ui`.

peknis · 2025-03-19T11:11:49Z

doc/nrf/includes/sample_dtm_radio_test_fem.txt

@@ -1,9 +1,10 @@
-You can add support for the nRF21540 front-end module (FEM) to the sample.
+You can add support for the nRF21540 or the nRF2220 front-end module (FEM) to the sample.


Suggested change

You can add support for the nRF21540 or the nRF2220 front-end module (FEM) to the sample.

You can add support for the nRF21540 or nRF2220 front-end module (FEM) to the sample.

peknis · 2025-03-19T11:15:29Z

doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst

  * Added loading of radio trims and a fix of a hardware errata for the nRF54H20 SoC to improve the RF performance.
+  * Added support for the ``nRF2220`` front-end module.


Suggested change

* Added loading of radio trims and a fix of a hardware errata for the nRF54H20 SoC to improve the RF performance.

* Added support for the ``nRF2220`` front-end module.

* Added:

* Loading of radio trims and a fix of a hardware errata for the nRF54H20 SoC to improve the RF performance.

* Support for the nRF2220 front-end module.

Support for the :ref: nRF2220 front-end module <ug_radio_fem_nrf2220ek>.

Good to link to the Developing with the nRF2220 EK guide.

peknis · 2025-03-19T11:16:23Z

doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst

  * Added loading of radio trims and a fix of a hardware errata for the nRF54H20 SoC to improve the RF performance.
+  * Added support for the ``nRF2220`` front-end module.


Suggested change

* Added loading of radio trims and a fix of a hardware errata for the nRF54H20 SoC to improve the RF performance.

* Added support for the ``nRF2220`` front-end module.

* Added:

* Loading of radio trims and a fix of a hardware errata for the nRF54H20 SoC to improve the RF performance.

* Support for the ``nRF2220`` front-end module.

Support for the :ref: nRF2220 front-end module <ug_radio_fem_nrf2220ek>.

Good to link to the Developing with the nRF2220 EK guide.

grochu

The code looks good, but I'd like to clarify details of different scenarios of power/gain control:

how does the CONFIG_DTM_POWER_CONTROL_AUTOMATIC option affect the nRF2220? Does this FEM allow an open-loop gain control at all? Is there a register where the direct gain value can be set if this option is disabled, when user sends the FEM_TX_POWER_CONTROL_SET command (length = 4 in a VS command)? Is the register value encoded the same way?
the same question goes for Radio Test

Please align these vendor-specific commands with the new FEM if needed. Maybe the CONFIG_DTM_POWER_CONTROL_AUTOMATIC option doesn't apply to nRF2220? Please align documentation in this aspect.
Additionally, antenna selection is not available for this FEM.

umapraseeda · 2025-03-25T10:40:06Z

doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst

+  * Added:
+
+    * Loading of radio trims and a fix of a hardware errata for the nRF54H20 SoC to improve the RF performance.
+    * Support for the :ref: nRF2220 front-end module <ug_radio_fem_nrf2220ek>.


Suggested change

* Support for the :ref: nRF2220 front-end module <ug_radio_fem_nrf2220ek>.

* Support for the :ref:`nRF2220 front-end module <ug_radio_fem_nrf2220ek>`.

umapraseeda · 2025-03-25T10:40:50Z

doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst

+  * Added:
+
+    * Loading of radio trims and a fix of a hardware errata for the nRF54H20 SoC to improve the RF performance.
+    * Support for the :ref: nRF2220 front-end module <ug_radio_fem_nrf2220ek>.


Suggested change

* Support for the :ref: nRF2220 front-end module <ug_radio_fem_nrf2220ek>.

* Support for the :ref:`nRF2220 front-end module <ug_radio_fem_nrf2220ek>`.

grochu

Adding a doc related comment. Otherwise the PR looks good to me.

grochu · 2025-03-26T10:32:13Z

samples/peripheral/radio_test/README.rst


 .. include:: /includes/sample_dtm_radio_test_fem.txt

-You can configure the nRF21540 front-end module (FEM) transmitted power control, antenna output and activation delay using the main shell commands of the :ref:`radio_test_ui`.
+You can configure the front-end module (FEM) transmitted power control, antenna output, and activation delay using the main shell commands of the :ref:`radio_test_ui`.


Please add a note to make it clear to the users, that each FEM has different interface and not all commands will work the same way, and some may not be supported, maybe something like:
Note: each front-end module (FEM) has different capabilities and operating modes, so some commands may not be supported by a specific FEM and those supported may work differently on different FEMs.

grochu · 2025-03-26T10:33:05Z

samples/bluetooth/direct_test_mode/README.rst


 .. include:: /includes/sample_dtm_radio_test_fem.txt

-You can configure the transmitted power gain, antenna output and activation delay in nRF21540 using vendor-specific commands, see `Vendor-specific packet payload`_.
+You can configure the transmitted power gain, antenna output, and activation delay in FEMs using vendor-specific commands, see `Vendor-specific packet payload`_.


Please add a note to make it clear to the users, that each FEM has different interface and not all commands will work the same way, and some may not be supported, maybe something like:
Note: each front-end module (FEM) has different capabilities and operating modes, so some commands may not be supported by a specific FEM and those supported may work differently on different FEMs.

peknis · 2025-03-26T11:29:34Z

samples/bluetooth/direct_test_mode/README.rst

+You can configure the transmitted power gain, antenna output, and activation delay in FEMs using vendor-specific commands, see `Vendor-specific packet payload`_.
+
+.. note::
+   Each front-end module (FEM) has different capabilities and operating modes, so some commands may not be supported by a specific front-end module (FEM) and those supported may work differently on different front-end modules (FEMs).


Suggested change

Each front-end module (FEM) has different capabilities and operating modes, so some commands may not be supported by a specific front-end module (FEM) and those supported may work differently on different front-end modules (FEMs).

Each front-end module (FEM) has different capabilities and operating modes, so some commands may not be supported by a specific FEM and those supported may work differently on different FEMs.

peknis · 2025-03-26T11:30:17Z

samples/peripheral/radio_test/README.rst

+You can configure the front-end module (FEM) transmitted power control, antenna output, and activation delay using the main shell commands of the :ref:`radio_test_ui`.
+
+.. note::
+   Each front-end module (FEM) has different capabilities and operating modes, so some commands may not be supported by a specific front-end module (FEM) and those supported may work differently on different front-end modules (FEMs).


Suggested change

Each front-end module (FEM) has different capabilities and operating modes, so some commands may not be supported by a specific front-end module (FEM) and those supported may work differently on different front-end modules (FEMs).

Each front-end module (FEM) has different capabilities and operating modes, so some commands may not be supported by a specific FEM and those supported may work differently on different FEMs.

Add nRF2220EK support for: - direct_test_mode - radio_test samples. Jira: NCSDK-31910 Signed-off-by: Dominik Chat <dominik.chat@nordicsemi.no>

dchat-nordic requested review from grochu, rakons, doki-nordic, peknis and maje-emb March 19, 2025 10:47

dchat-nordic requested review from a team as code owners March 19, 2025 10:47

github-actions bot added the doc-required PR must not be merged without tech writer approval. label Mar 19, 2025

peknis requested changes Mar 19, 2025

View reviewed changes

grochu requested changes Mar 19, 2025

View reviewed changes

dchat-nordic marked this pull request as draft March 20, 2025 13:43

dchat-nordic force-pushed the fem22 branch from 35f9f0b to d0165a7 Compare March 25, 2025 10:03

dchat-nordic marked this pull request as ready for review March 25, 2025 10:04

dchat-nordic force-pushed the fem22 branch 2 times, most recently from 6d7e72e to 4caefd6 Compare March 25, 2025 10:33

dchat-nordic requested review from divipillai, grochu and peknis March 25, 2025 10:33

umapraseeda requested changes Mar 25, 2025

View reviewed changes

dchat-nordic force-pushed the fem22 branch from 4caefd6 to ebcb7e8 Compare March 25, 2025 11:03

dchat-nordic requested a review from umapraseeda March 25, 2025 11:03

peknis approved these changes Mar 25, 2025

View reviewed changes

divipillai approved these changes Mar 25, 2025

View reviewed changes

umapraseeda approved these changes Mar 26, 2025

View reviewed changes

grochu reviewed Mar 26, 2025

View reviewed changes

grochu approved these changes Mar 26, 2025

View reviewed changes

dchat-nordic force-pushed the fem22 branch from ebcb7e8 to c38768b Compare March 26, 2025 11:26

dchat-nordic requested a review from peknis March 26, 2025 11:26

peknis requested changes Mar 26, 2025

View reviewed changes

samples: Add nRF2220EK support for RT and DTM samples

c5709d2

Add nRF2220EK support for: - direct_test_mode - radio_test samples. Jira: NCSDK-31910 Signed-off-by: Dominik Chat <dominik.chat@nordicsemi.no>

dchat-nordic force-pushed the fem22 branch from c38768b to c5709d2 Compare March 26, 2025 11:33

dchat-nordic requested a review from peknis March 26, 2025 11:33

peknis approved these changes Mar 26, 2025

View reviewed changes

grochu approved these changes Mar 26, 2025

View reviewed changes

maje-emb approved these changes Mar 26, 2025

View reviewed changes

rlubos merged commit c8d1abe into nrfconnect:main Mar 26, 2025
14 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

samples: Add nRF2220EK support for RT and DTM samples #21027

samples: Add nRF2220EK support for RT and DTM samples #21027

dchat-nordic commented Mar 19, 2025

NordicBuilder commented Mar 19, 2025 •

edited

Loading

sonarqubecloud bot commented Mar 19, 2025

github-actions bot commented Mar 19, 2025

peknis Mar 19, 2025

peknis Mar 19, 2025

peknis Mar 19, 2025

peknis Mar 19, 2025

peknis Mar 19, 2025

peknis Mar 19, 2025

divipillai Mar 25, 2025 •

edited

Loading

peknis Mar 19, 2025

divipillai Mar 25, 2025 •

edited

Loading

grochu left a comment •

edited

Loading

umapraseeda Mar 25, 2025

umapraseeda Mar 25, 2025

grochu left a comment

grochu Mar 26, 2025

dchat-nordic Mar 26, 2025

grochu Mar 26, 2025

dchat-nordic Mar 26, 2025

peknis Mar 26, 2025

peknis Mar 26, 2025


		To add support for the nRF21540 FEM, build the sample for a board containing nRF21540 FEM like :ref:`nrf21540dk/nrf52840 <zephyr:nrf21540dk_nrf52840>` or create a devicetree overlay file describing how FEM is connected to nRF5 SoC in your device.
		To add support for the FEM, build the sample for a board containing FEM like :ref:`nrf21540dk/nrf52840 <zephyr:nrf21540dk_nrf52840>` or create a devicetree overlay file describing how FEM is connected to nRF5 SoC in your device.

	If you use the nRF2220EK, append ``nrf2220ek`` shield to your build command instructing build system to append the appropriate devicetree overlay file.
	If you use the nRF2220 EK, append the ``nrf2220ek`` shield to your build command instructing the build system to append the appropriate devicetree overlay file.

	You can configure the transmitted power gain, antenna output and activation delay in FEMs using vendor-specific commands, see `Vendor-specific packet payload`_.
	You can configure the transmitted power gain, antenna output, and activation delay in FEMs using vendor-specific commands, see `Vendor-specific packet payload`_.

	You can configure the front-end module (FEM) transmitted power control, antenna output and activation delay using the main shell commands of the :ref:`radio_test_ui`.
	You can configure the front-end module (FEM) transmitted power control, antenna output, and activation delay using the main shell commands of the :ref:`radio_test_ui`.

		@@ -1,9 +1,10 @@
		You can add support for the nRF21540 front-end module (FEM) to the sample.
		You can add support for the nRF21540 or the nRF2220 front-end module (FEM) to the sample.

		* Added loading of radio trims and a fix of a hardware errata for the nRF54H20 SoC to improve the RF performance.
		* Added support for the ``nRF2220`` front-end module.

	* Support for the :ref: nRF2220 front-end module <ug_radio_fem_nrf2220ek>.
	* Support for the :ref:`nRF2220 front-end module <ug_radio_fem_nrf2220ek>`.

	Each front-end module (FEM) has different capabilities and operating modes, so some commands may not be supported by a specific front-end module (FEM) and those supported may work differently on different front-end modules (FEMs).
	Each front-end module (FEM) has different capabilities and operating modes, so some commands may not be supported by a specific FEM and those supported may work differently on different FEMs.

samples: Add nRF2220EK support for RT and DTM samples #21027

samples: Add nRF2220EK support for RT and DTM samples #21027

Conversation

dchat-nordic commented Mar 19, 2025

NordicBuilder commented Mar 19, 2025 • edited Loading

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

sonarqubecloud bot commented Mar 19, 2025

Quality Gate passed

github-actions bot commented Mar 19, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

divipillai Mar 25, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

divipillai Mar 25, 2025 • edited Loading

Choose a reason for hiding this comment

grochu left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

grochu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NordicBuilder commented Mar 19, 2025 •

edited

Loading

divipillai Mar 25, 2025 •

edited

Loading

divipillai Mar 25, 2025 •

edited

Loading

grochu left a comment •

edited

Loading