Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: 802154_phy_test: Remove nrf54h20dk support #21053

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

dawidprzybylo
Copy link
Contributor

Remove nrf54h20dk/nrf54h20/cpurad platform support for 802154_phy_test sample.yaml configuration
Ref: KRKNWK-20094

@dawidprzybylo dawidprzybylo requested a review from a team as a code owner March 20, 2025 08:12
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Mar 20, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Mar 20, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 3

Inputs:

Sources:

sdk-nrf: PR head: a7219b19bd605b84ab6a82a40cf979bb5ec0b4d2

more details

sdk-nrf:

PR head: a7219b19bd605b84ab6a82a40cf979bb5ec0b4d2
merge base: 4c623e64e60633b234c20150d040be7e560c5b50
target head (main): 73c22404b5f96682749c379881cddb473eb84978
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (2)
samples
│  ├── peripheral
│  │  ├── 802154_phy_test
│  │  │  ├── README.rst
│  │  │  │ sample.yaml

Outputs:

Toolchain

Version: 4ffa2202d5
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:4ffa2202d5_e579f9fbe6

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 40
  • ✅ Integration tests
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

Copy link

github-actions bot commented Mar 20, 2025

You can find the documentation preview for this PR here.

Preview links for modified nRF Connect SDK documents:

https://ncsdoc.z6.web.core.windows.net/PR-21053/nrf/samples/peripheral/802154_phy_test/README.html

@dawidprzybylo
Copy link
Contributor Author

dawidprzybylo commented Mar 20, 2025

Compliance issue reported on NCS CI team channel, waiting for fix...

@dawidprzybylo dawidprzybylo removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Mar 20, 2025
@piotrkoziar
Copy link
Contributor

@dawidprzybylo There is one mention of nrf54H in README.rst:
.. note::
|54H_engb_2_8|

can we remove it also?

@piotrkoziar
Copy link
Contributor

piotrkoziar commented Mar 20, 2025

@dawidprzybylo There is also
SOC_NRF54H20_CPURAD in the Kconfig.sysbuild, can we remove it too?
And generally, shall we remove all files related to the nrf54H20? Such as: overlays, board configs etc. in the 802154_phy_test?

Edit: talked with Dawid, we will keep them

Remove nrf54h20dk/nrf54h20/cpurad platform support for
802154_phy_test sample.yaml configuration
Ref: KRKNWK-20094

Signed-off-by: Dawid Przybylo <dawid.przybylo@nordicsemi.no>
@dawidprzybylo dawidprzybylo requested a review from a team as a code owner March 20, 2025 13:24
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Mar 20, 2025
@greg-fer
Copy link
Contributor

Does this require a changelog entry, @dawidprzybylo ? Your call.

@dawidprzybylo
Copy link
Contributor Author

Does this require a changelog entry, @dawidprzybylo ? Your call.

No, nrf54h is in experimental anyway

@rlubos rlubos merged commit 8c62314 into nrfconnect:main Mar 20, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants