samples: cellular: modem_shell: Fix printing of PDN events #21064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog-entry-required
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 0ee1c5f558d1276682b7e7b729c7f6200614cd59 more detailssdk-nrf:
Github labels
List of changed files detected by CI (1)Outputs:ToolchainVersion: Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
trantanen
approved these changes
Mar 20, 2025
Two PDN events were missing from a mapping table. Furthermore, if an event which was missing from the table was received, modem_shell crashed. Added the missing events and implemented mapping using similar approach which is used elsewhere in the sample, which handles missing items gracefully. TNSW-66408 Signed-off-by: Tommi Kangas <tommi.kangas@nordicsemi.no>
tokangas
force-pushed
the
mosh_pdn_event_mapping_fix
branch
from
cd82c20 to
0ee1c5f
Compare
|
stig-bjorlykke
approved these changes
Mar 21, 2025
tokangas
removed
the
changelog-entry-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two PDN events were missing from a mapping table. Furthermore, if an event which was missing from the table was received, modem_shell crashed. Added the missing events and implemented mapping using similar approach which is used elsewhere in the sample, which handles missing items gracefully.
TNSW-66408