Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nrf_security: Various fixes regarding the recent Oberon PSA update #21065

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Vge0rge
Copy link
Contributor

@Vge0rge Vge0rge commented Mar 20, 2025

Read commit messages for description.

@Vge0rge Vge0rge requested review from a team as code owners March 20, 2025 13:38
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Mar 20, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Mar 20, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 11

Inputs:

Sources:

sdk-nrf: PR head: d9712ff6c6bf69fc1e55c1f9b4e2afe3874d0dc3

more details

sdk-nrf:

PR head: d9712ff6c6bf69fc1e55c1f9b4e2afe3874d0dc3
merge base: d0c3d7f02a4f3260a048a5310b43c5c43e136a7c
target head (main): 762492f3d6d86efb602182ce86ce21a3be588260
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (6)
doc
│  ├── nrf
│  │  ├── links.txt
│  │  ├── releases_and_maturity
│  │  │  ├── releases
│  │  │  │  │ release-notes-changelog.rst
subsys
│  ├── nrf_security
│  │  ├── Kconfig.psa
│  │  ├── Kconfig.psa.nordic
│  │  ├── cmake
│  │  │  │ psa_crypto_config.cmake
│  │  ├── configs
│  │  │  │ psa_crypto_config.h.template

Outputs:

Toolchain

Version: 4ffa2202d5
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:4ffa2202d5_e579f9fbe6

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ❌ Build twister
    • sdk-nrf test count: 1703
  • ❌ Integration tests
    • ❌ test-fw-nrfconnect-chip
    • ❌ test-fw-nrfconnect-nrf-iot_cloud
    • ❌ test-fw-nrfconnect-nrf_crypto
    • ❌ test-fw-nrfconnect-tfm
    • ❌ test-sdk-find-my
    • ❌ test-sdk-dfu
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@Vge0rge Vge0rge changed the title nrf_security: Various fixed regarding the recent Oberon PSA update nrf_security: Various fixes regarding the recent Oberon PSA update Mar 20, 2025
Copy link
Contributor

@degjorva degjorva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor nits

@Vge0rge Vge0rge force-pushed the oberon_upmerge_fixes branch from dd78350 to 22a6fea Compare March 20, 2025 14:05
@Vge0rge Vge0rge force-pushed the oberon_upmerge_fixes branch from 22a6fea to cf10244 Compare March 20, 2025 14:22
@Vge0rge Vge0rge requested a review from a team as a code owner March 21, 2025 11:31
@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label Mar 21, 2025
@@ -108,6 +108,14 @@ Security
* Support for HKDF-Expand and HKDF-Extract in CRACEN.
* Support for Ed25519ph(HashEdDSA) to CRACEN.

* Updated the Oberon PSA core to version 1.3.4 which introduces support for the following:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fully agree. Once again, I forgot to check the file name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I moved the change to the suggested file and I integrated @peknis suggestion.

Copy link

github-actions bot commented Mar 21, 2025

You can find the documentation preview for this PR here.

Preview links for modified nRF Connect SDK documents:

https://ncsdoc.z6.web.core.windows.net/PR-21065/nrf/releases_and_maturity/releases/release-notes-changelog.html

Vge0rge added 5 commits March 21, 2025 13:31
Update the prompts to write [EXPERIMENTAL] in the prompt
apart only selecting the experimental symbol.

Signed-off-by: Georgios Vasilakis <georgios.vasilakis@nordicsemi.no>
In the psa_crypto template file.

Signed-off-by: Georgios Vasilakis <georgios.vasilakis@nordicsemi.no>
Fix typos and do minor improvements in the Kconfig
description and prompts.

Signed-off-by: Georgios Vasilakis <georgios.vasilakis@nordicsemi.no>
In the Kconfig.psa.nordic file because this file is meant to be used
with PSA it makes sense to use PSA_PROMPTLESS.

Signed-off-by: Georgios Vasilakis <georgios.vasilakis@nordicsemi.no>
This makes sure that the MBEDTLS_PSA_KEY_STORE_DYNAMIC is never
forwarded to the build.
It also makes the help text more descriptive.

Signed-off-by: Georgios Vasilakis <georgios.vasilakis@nordicsemi.no>
@Vge0rge Vge0rge force-pushed the oberon_upmerge_fixes branch from 3154fde to 580b3b7 Compare March 21, 2025 12:31
@github-actions github-actions bot removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Mar 21, 2025
@Vge0rge Vge0rge force-pushed the oberon_upmerge_fixes branch from 580b3b7 to a9740a7 Compare March 21, 2025 13:22
@Vge0rge Vge0rge requested a review from a team as a code owner March 21, 2025 13:22
Update the changelog with the new features introduced
with the new Oberon PSA core.

Signed-off-by: Georgios Vasilakis <georgios.vasilakis@nordicsemi.no>
@Vge0rge Vge0rge force-pushed the oberon_upmerge_fixes branch from be026e1 to d9712ff Compare March 21, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants