samples: matter: Added custom events to the Matter MS sample #21066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
doc-required
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: bd80505cbe906faa4121d73987beb16c676dbbf5 more detailssdk-nrf:
Github labels
List of changed files detected by CI (13)Outputs:ToolchainVersion: 4ffa2202d5 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
|
You can find the documentation preview for this PR here. Preview links for modified nRF Connect SDK documents: https://ncsdoc.z6.web.core.windows.net/PR-21066/nrf/protocols/matter/getting_started/custom_clusters.html |
peknis
requested changes
Mar 21, 2025
| @@ -153,6 +153,8 @@ See the description of each element in the following tabs: | |||
| * ``source`` - Specifies whether the event originates from the client or server. | |||
| * ``code`` - A unique identifier for the event within the cluster. | |||
| * ``name`` - The name of the event. | |||
| * ``priority`` - The priority of the event. | |||
| The valid values are 'debug', 'info', and 'critical'. | |||
There was a problem hiding this comment.
Suggested change
| The valid values are 'debug', 'info', and 'critical'. | |
| The valid values are 'debug', 'info', and 'critical'. |
Should these be between double backticks. Or is that single quote character needed here?
There was a problem hiding this comment.
I think that double backticks should be good, thanks for the catch.
Added custom events to NordicDevKit and Basic Information clusters: * UserButtonChanged emitted on UserButton state change * RandomNumberChanged emitted on RandomNumber change Updated the documentation to contain steps for the events. Additionally fixed ids for attributes and commands that were not compatible with the spec and fixed few minor issues in the documentation. Signed-off-by: Kamil Kasperczyk <kamil.kasperczyk@nordicsemi.no>
kkasperczyk-no
force-pushed
the
ms_events
branch
from
fbc834e to
bd80505
Compare
|
ArekBalysNordic
approved these changes
Mar 21, 2025
peknis
approved these changes
Mar 21, 2025
ArekBalysNordic
removed
the
changelog-entry-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added custom events to NordicDevKit and Basic Information clusters:
Updated the documentation to contain steps for the events.
Additionally fixed ids for attributes and commands that were not compatible with the spec and fixed few minor issues in the documentation.