Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samples: wifi: Replace nrfjprog with nrfutil #21108

Merged
merged 2 commits into from
Mar 25, 2025
Merged

samples: wifi: Replace nrfjprog with nrfutil #21108

merged 2 commits into from
Mar 25, 2025

Conversation

D-Triveni
Copy link
Contributor

Replace all instances of nrfjprog commands with
nrfutil commands as nrfjprog is going to be deprecated.

Fixes SHEL-3520.

@D-Triveni
samples: wifi: Replace nrfjprog with nrfutil
65f6705 
Replace all instances of `nrfjprog` commands with
`nrfutil` commands as nrfjprog is going to be deprecated.

Fixes SHEL-3520.

Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no>
@D-Triveni D-Triveni requested a review from a team as a code owner March 24, 2025 09:30
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Mar 24, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Mar 24, 2025 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 5

Inputs:

Sources:

sdk-nrf: PR head: 0e133b8c2b13d3977e589844cc59bf2048e7a70f

more details

sdk-nrf:

PR head: 0e133b8c2b13d3977e589844cc59bf2048e7a70f
merge base: 86638730d978ed2770e2466a1ee2b462e6815a99
target head (main): 831d14c8a32905b89d6cadb9f01b94facb403865
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (5) 
doc
│  ├── nrf
│  │  ├── gsg_guides
│  │  │  │ nrf7002_gs.rst
│  │  ├── releases_and_maturity
│  │  │  ├── releases
│  │  │  │  │ release-notes-changelog.rst
samples
│  ├── wifi
│  │  ├── ble_coex
│  │  │  │ README.rst
│  │  ├── shell
│  │  │  │ README.rst
│  │  ├── thread_coex
│  │  │  │ README.rst

Outputs:

Toolchain

Version:
Build docker image:

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain
  • ◻️ Build twister
  • ◻️ Integration tests
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 24, 2025 •
edited
Loading

You can find the documentation preview for this PR here.

Preview links for modified nRF Connect SDK documents:

https://ncsdoc.z6.web.core.windows.net/PR-21108/nrf/gsg_guides/nrf7002_gs.html
https://ncsdoc.z6.web.core.windows.net/PR-21108/nrf/releases_and_maturity/releases/release-notes-changelog.html
https://ncsdoc.z6.web.core.windows.net/PR-21108/nrf/samples/wifi/ble_coex/README.html
https://ncsdoc.z6.web.core.windows.net/PR-21108/nrf/samples/wifi/shell/README.html
https://ncsdoc.z6.web.core.windows.net/PR-21108/nrf/samples/wifi/thread_coex/README.html

krish2718
krish2718 requested changes Mar 24, 2025
View reviewed changes
Copy link
Contributor

@krish2718 krish2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still few nrfjprog references in other Wi-Fi samples too, please fix them.

ag nrfjprog samples/wifi/ --ignore-dir "build*"
samples/wifi/ble_coex/README.rst
204:      nrfjprog --com
207:         |nrfjprog_deprecation_note|

samples/wifi/shell/README.rst
95:   nrfjprog --deviceversion
97:   nrfjprog --recover
99:   nrfjprog --deviceversion
104:    |nrfjprog_deprecation_note|

samples/wifi/thread_coex/README.rst
187:      nrfjprog --com
190:         |nrfjprog_deprecation_note|

@D-Triveni D-Triveni force-pushed the rem-nrfjprog-in-wifi-shell-doc branch from 33dfb55 to 65f6705 Compare March 24, 2025 12:06
@D-Triveni
Copy link
Contributor Author

I still few nrfjprog references in other Wi-Fi samples too, please fix them.

ag nrfjprog samples/wifi/ --ignore-dir "build*"
samples/wifi/ble_coex/README.rst
204:      nrfjprog --com
207:         |nrfjprog_deprecation_note|

samples/wifi/shell/README.rst
95:   nrfjprog --deviceversion
97:   nrfjprog --recover
99:   nrfjprog --deviceversion
104:    |nrfjprog_deprecation_note|

samples/wifi/thread_coex/README.rst
187:      nrfjprog --com
190:         |nrfjprog_deprecation_note|

Addressed.

@D-Triveni D-Triveni changed the title samples: wifi: shell: Replace nrfjprog with nrfutil samples: wifi: Replace nrfjprog with nrfutil Mar 24, 2025
@D-Triveni D-Triveni requested a review from muraliThokala March 24, 2025 12:35
@greg-fer greg-fer removed their request for review March 24, 2025 13:20
@greg-fer
Copy link
Contributor

I'm removing myself from the review -- I defer doc review to the ncs-wifi-doc group.

richabp
richabp requested changes Mar 24, 2025
View reviewed changes
Copy link
Contributor

@richabp richabp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a Changelog entry is required for this update.

@D-Triveni
doc: Replace nRF Command Line Tools with nrfutil in nRF70 doc
0e133b8 
Replace `nRF Command Line Tools` with `nrfutil`
as `nRF Command Line Tools` are about to be archived.

Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no>
@D-Triveni D-Triveni force-pushed the rem-nrfjprog-in-wifi-shell-doc branch from 232d432 to 1626ec9 Compare March 25, 2025 07:13
@D-Triveni D-Triveni requested a review from a team as a code owner March 25, 2025 07:13
@github-actions github-actions bot removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Mar 25, 2025
@D-Triveni D-Triveni force-pushed the rem-nrfjprog-in-wifi-shell-doc branch from 1626ec9 to 0e133b8 Compare March 25, 2025 09:24
@rlubos rlubos merged commit bb30f3a into nrfconnect:main Mar 25, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krish2718 krish2718 krish2718 approved these changes

@peknis peknis peknis approved these changes

@richabp richabp richabp approved these changes

@sachinthegreen sachinthegreen sachinthegreen approved these changes

@muraliThokala muraliThokala muraliThokala approved these changes

@VivekUppunda VivekUppunda VivekUppunda approved these changes

@bama-nordic bama-nordic Awaiting requested review from bama-nordic

@krga2022 krga2022 Awaiting requested review from krga2022

Assignees
No one assigned
Labels
doc-required PR must not be merged without tech writer approval.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@D-Triveni @NordicBuilder @greg-fer @peknis @richabp @krish2718 @sachinthegreen @muraliThokala @VivekUppunda @rlubos