-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net: rpc: openthread: add networkdiagnostic APIs #21110
net: rpc: openthread: add networkdiagnostic APIs #21110
Conversation
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 1900bb3d4dbe88eb693fd0032605106e4af867fb more detailssdk-nrf:
Github labels
List of changed files detected by CI (6)
Outputs:ToolchainVersion: 4ffa2202d5 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
f7dcfdf
to
c5acfad
Compare
c5acfad
to
9ac2f03
Compare
You can find the documentation preview for this PR here. Preview links for modified nRF Connect SDK documents: https://ncsdoc.z6.web.core.windows.net/PR-21110/nrf/libraries/networking/ot_rpc.html |
7d2fc8e
to
0ae6d4a
Compare
b772421
to
ac5b779
Compare
sizeof(aNetworkDiagTlv->mData.mVendorAppUrl)); | ||
break; | ||
case OT_NETWORK_DIAGNOSTIC_TLV_NETWORK_DATA: | ||
aNetworkDiagTlv->mData.mNetworkData.mCount = nrf_rpc_decode_uint(ctx); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
encoding the bstr size as a separate uint seems a bit redundant but I guess we need a better helper than nrf_rpc_decode_buffer
for decoding var-length buffers, so we can leave it for now and fix later :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah. I think it would be nice if we could also return actual size in nrf_rpc_decode_buffer
, similar as nrf_rpc_decode_buffer_ptr_and_size
ac5b779
to
5d38461
Compare
Add APIs for getting and resetting network diagnostic TLVs. Signed-off-by: Maciej Baczmanski <maciej.baczmanski@nordicsemi.no>
5d38461
to
1900bb3
Compare
Add APIs for getting and resetting network diagnostic TLVs.