Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: rpc: openthread: add networkdiagnostic APIs #21110

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

maciejbaczmanski
Copy link
Member

Add APIs for getting and resetting network diagnostic TLVs.

@maciejbaczmanski maciejbaczmanski requested review from a team as code owners March 24, 2025 10:31
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Mar 24, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Mar 24, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 12

Inputs:

Sources:

sdk-nrf: PR head: 1900bb3d4dbe88eb693fd0032605106e4af867fb

more details

sdk-nrf:

PR head: 1900bb3d4dbe88eb693fd0032605106e4af867fb
merge base: b4b0ece65ef9c45fd32bea41c788eec7556595b0
target head (main): 8798f86aa24582bd18256cbaca76cb25e25096cb
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (6)
doc
│  ├── nrf
│  │  ├── libraries
│  │  │  ├── networking
│  │  │  │  │ ot_rpc.rst
samples
│  ├── nrf_rpc
│  │  ├── protocols_serialization
│  │  │  ├── client
│  │  │  │  ├── src
│  │  │  │  │  │ ot_shell.c
subsys
│  ├── net
│  │  ├── openthread
│  │  │  ├── rpc
│  │  │  │  ├── client
│  │  │  │  │  │ ot_rpc_netdiag.c
│  │  │  │  ├── common
│  │  │  │  │  │ ot_rpc_ids.h
│  │  │  │  ├── server
│  │  │  │  │  │ ot_rpc_netdiag.c
tests
│  ├── subsys
│  │  ├── net
│  │  │  ├── openthread
│  │  │  │  ├── rpc
│  │  │  │  │  ├── server
│  │  │  │  │  │  ├── src
│  │  │  │  │  │  │  │ netdiag_suite.c

Outputs:

Toolchain

Version: 4ffa2202d5
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:4ffa2202d5_8bf7ca4353

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 522
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-rpc
    • ✅ test-fw-nrfconnect-thread
    • ✅ test-fw-nrfconnect-ps
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

Copy link

You can find the documentation preview for this PR here.

Preview links for modified nRF Connect SDK documents:

https://ncsdoc.z6.web.core.windows.net/PR-21110/nrf/libraries/networking/ot_rpc.html

@maciejbaczmanski maciejbaczmanski force-pushed the ps_netdiag_apis branch 2 times, most recently from 7d2fc8e to 0ae6d4a Compare March 24, 2025 12:28
@maciejbaczmanski maciejbaczmanski force-pushed the ps_netdiag_apis branch 5 times, most recently from b772421 to ac5b779 Compare March 24, 2025 17:40
sizeof(aNetworkDiagTlv->mData.mVendorAppUrl));
break;
case OT_NETWORK_DIAGNOSTIC_TLV_NETWORK_DATA:
aNetworkDiagTlv->mData.mNetworkData.mCount = nrf_rpc_decode_uint(ctx);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

encoding the bstr size as a separate uint seems a bit redundant but I guess we need a better helper than nrf_rpc_decode_buffer for decoding var-length buffers, so we can leave it for now and fix later :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah. I think it would be nice if we could also return actual size in nrf_rpc_decode_buffer, similar as nrf_rpc_decode_buffer_ptr_and_size

Add APIs for getting and resetting network diagnostic TLVs.

Signed-off-by: Maciej Baczmanski <maciej.baczmanski@nordicsemi.no>
@maciejbaczmanski maciejbaczmanski merged commit 7f5401f into nrfconnect:main Mar 26, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants