Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: openthread: rpc: fix handle leak in CoAP RPC server #21116

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

Damian-Nordic
Copy link
Contributor

  1. Fix message handle leak after sending a CoAP response.
  2. Add unit tests to verify that handle is allocated/freed.
  3. Improve CoAP RPC server thread safety.
  4. Other minor fixes and improvements.

@Damian-Nordic Damian-Nordic requested a review from a team as a code owner March 24, 2025 12:19
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Mar 24, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 4

Inputs:

Sources:

sdk-nrf: PR head: 8631afa312f149e61118884745d4389da8696bd9

more details

sdk-nrf:

PR head: 8631afa312f149e61118884745d4389da8696bd9
merge base: 4bd5e19d4f0d5c24b5e58e5ddb99c328f37bd490
target head (main): 4f46b3588ad3f815af8d47332c82649417470e9f
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (3)
subsys
│  ├── net
│  │  ├── openthread
│  │  │  ├── rpc
│  │  │  │  ├── server
│  │  │  │  │  ├── ot_rpc_coap.c
│  │  │  │  │  │ ot_rpc_message.c
tests
│  ├── subsys
│  │  ├── net
│  │  │  ├── openthread
│  │  │  │  ├── rpc
│  │  │  │  │  ├── server
│  │  │  │  │  │  ├── src
│  │  │  │  │  │  │  │ coap_suite.c

Outputs:

Toolchain

Version: 4ffa2202d5
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:4ffa2202d5_8bf7ca4353

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 522
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-thread
    • ✅ test-fw-nrfconnect-ps
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Mar 24, 2025
1. Fix message handle leak after sending a CoAP response.
2. Add unit tests to verify that handle is allocated/freed.
3. Improve CoAP RPC server thread safety.
4. Other minor fixes and improvements.

Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no>
@Damian-Nordic Damian-Nordic removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Mar 24, 2025
@nordicjm nordicjm merged commit af1d964 into nrfconnect:main Mar 24, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants