Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: nrf_rpc: ps_server: RPC alive LED #21122

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

Damian-Nordic
Copy link
Contributor

  1. Add nrf_rpc_uart_initialized_hook() that is called when an nRF RPC UART transport instance gets ready to receive packets.
  2. Use the hook in the PS server sample to toggle the LED selected with /alias/rpc-alive-led DTS property when the RPC transport is ready.

1. Add nrf_rpc_uart_initialized_hook() that is called when
   an nRF RPC UART transport instance gets ready to receive
   packets.
2. Use the hook in the PS server sample to toggle the LED
   selected with /alias/rpc-alive-led DTS property when
   the RPC transport is ready.

Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no>
@Damian-Nordic Damian-Nordic requested review from a team as code owners March 24, 2025 15:32
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Mar 24, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Mar 24, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 1

Inputs:

Sources:

sdk-nrf: PR head: 0900dd0cb4427800ae2e1ec0c0c536fdd44a412e

more details

sdk-nrf:

PR head: 0900dd0cb4427800ae2e1ec0c0c536fdd44a412e
merge base: 4bd5e19d4f0d5c24b5e58e5ddb99c328f37bd490
target head (main): dd6904a744c8e663b00468fbca9de11733150c88
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (6)
include
│  ├── nrf_rpc
│  │  │ nrf_rpc_uart.h
samples
│  ├── nrf_rpc
│  │  ├── protocols_serialization
│  │  │  ├── server
│  │  │  │  ├── Kconfig
│  │  │  │  ├── boards
│  │  │  │  │  ├── nrf52840dk_nrf52840.overlay
│  │  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp.overlay
│  │  │  │  ├── src
│  │  │  │  │  │ main.c
subsys
│  ├── nrf_rpc
│  │  │ nrf_rpc_uart.c

Outputs:

Toolchain

Version: 4ffa2202d5
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:4ffa2202d5_8bf7ca4353

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 588
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-ble_samples
    • ✅ test-fw-nrfconnect-rpc
    • ✅ test-fw-nrfconnect-rs
    • ✅ test-fw-nrfconnect-fem
    • ✅ test-sdk-dfu
    • ✅ test-fw-nrfconnect-ps
    • ⚠️ test_ble_nrf_config
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

Copy link

You can find the documentation preview for this PR here.

Copy link
Contributor

@kderda kderda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Damian-Nordic Damian-Nordic removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Mar 26, 2025
@Damian-Nordic
Copy link
Contributor Author

@nordicjm @tejlmand Please review

Copy link
Contributor

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not how callbacks are done in zephyr but will approve anyhow

@Damian-Nordic
Copy link
Contributor Author

@nordicjm Could you elaborate?

@rlubos rlubos merged commit 0b0505a into nrfconnect:main Mar 26, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants