Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nrfcloud: use app jwt library #21142

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

maxd-nordic
Copy link
Contributor

Replace internal JWT implementation with the app_jwt library.
Requires the usage of prime256v1 keys.
Adds a unit test for the app_jwt library.

@maxd-nordic maxd-nordic requested review from a team and ayla-nordicsemi as code owners March 25, 2025 14:18
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Mar 25, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Mar 25, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 8

Inputs:

Sources:

sdk-nrf: PR head: cfafdae141ea56222e82c619b53435b96cb4d2a8

more details

sdk-nrf:

PR head: cfafdae141ea56222e82c619b53435b96cb4d2a8
merge base: 7fa043ff26e1c878958200d3e69bc323008c76a4
target head (main): 7fa043ff26e1c878958200d3e69bc323008c76a4
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (12)
CODEOWNERS
doc
│  ├── nrf
│  │  ├── releases_and_maturity
│  │  │  ├── releases
│  │  │  │  │ release-notes-changelog.rst
include
│  │ app_jwt.h
lib
│  ├── app_jwt
│  │  ├── CMakeLists.txt
│  │  ├── Kconfig
│  │  │ app_jwt.c
subsys
│  ├── net
│  │  ├── lib
│  │  │  ├── nrf_cloud
│  │  │  │  ├── Kconfig
│  │  │  │  ├── src
│  │  │  │  │  │ nrf_cloud_jwt.c
tests
│  ├── lib
│  │  ├── app_jwt
│  │  │  ├── CMakeLists.txt
│  │  │  ├── prj.conf
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  │  │ testcase.yaml

Outputs:

Toolchain

Version: 4ffa2202d5
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:4ffa2202d5_8bf7ca4353

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ❌ Build twister
    • sdk-nrf test count: 367
  • ❌ Integration tests
    • ❌ test-fw-nrfconnect-nrf-iot_cloud
    • ❌ test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • ❌ test-fw-nrfconnect-nrf-iot_thingy91
    • ❌ test-fw-nrfconnect-nrf-iot_mosh
    • ❌ test-fw-nrfconnect-nrf-iot_positioning
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@maxd-nordic maxd-nordic force-pushed the nrfcloud-use-app-jwt branch from 2873c20 to 8405295 Compare March 25, 2025 14:22
@maxd-nordic maxd-nordic force-pushed the nrfcloud-use-app-jwt branch from 8405295 to 913df0e Compare March 25, 2025 14:30
@maxd-nordic maxd-nordic requested a review from a team as a code owner March 25, 2025 14:30
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Mar 25, 2025
@maxd-nordic maxd-nordic force-pushed the nrfcloud-use-app-jwt branch 2 times, most recently from 0d062a9 to 548c935 Compare March 25, 2025 14:34
Copy link

You can find the documentation preview for this PR here.

Preview links for modified nRF Connect SDK documents:

https://ncsdoc.z6.web.core.windows.net/PR-21142/nrf/releases_and_maturity/releases/release-notes-changelog.html

@maxd-nordic maxd-nordic force-pushed the nrfcloud-use-app-jwt branch 2 times, most recently from d49b653 to 62603d9 Compare March 25, 2025 15:07
This patch adds a unit test for the JWT library
to confirm that the results can be used with nRF Cloud.

Signed-off-by: Maximilian Deubel <maximilian.deubel@nordicsemi.no>
Replace internal JWT implementation with the app_jwt library.
Requires the usage of prime256v1 keys.

Signed-off-by: Maximilian Deubel <maximilian.deubel@nordicsemi.no>
@maxd-nordic maxd-nordic force-pushed the nrfcloud-use-app-jwt branch from 62603d9 to cfafdae Compare March 25, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants