Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app: conn_bridge: Fix uart cdc handler #21154

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

jorgenmk
Copy link
Contributor

App was not working when receiving RX bytes on CDC transport. Reworked interrupt handler.

@jorgenmk jorgenmk requested review from nordic-auko and a team as code owners March 26, 2025 09:37
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Mar 26, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Mar 26, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 6

Inputs:

Sources:

sdk-nrf: PR head: 94ad3f32a355e7431402e2746f42e199a696bd5c

more details

sdk-nrf:

PR head: 94ad3f32a355e7431402e2746f42e199a696bd5c
merge base: e2245b18abbb77413b95fe5a27b336fb98a3a275
target head (main): 0b0505af66b488d263f472b2eec6283a7201abed
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (1)
applications
│  ├── connectivity_bridge
│  │  ├── src
│  │  │  ├── modules
│  │  │  │  │ usb_cdc_handler.c

Outputs:

Toolchain

Version: 4ffa2202d5
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:4ffa2202d5_8bf7ca4353

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 28
  • ✅ Integration tests
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@jorgenmk jorgenmk force-pushed the fix-conn-bridge-cdc-irq branch from 7c75d17 to e489da7 Compare March 26, 2025 09:53
Copy link

You can find the documentation preview for this PR here.

@jorgenmk jorgenmk force-pushed the fix-conn-bridge-cdc-irq branch 2 times, most recently from 53eb6b7 to 49e699a Compare March 26, 2025 11:23
@jorgenmk jorgenmk added bugfix Fixes a known bug and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Mar 26, 2025
@jorgenmk jorgenmk force-pushed the fix-conn-bridge-cdc-irq branch from 49e699a to ea71aa3 Compare March 26, 2025 11:51
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Mar 26, 2025
App was not working when receiving RX bytes on CDC transport.
Reworked interrupt handler.

Signed-off-by: Jorgen Kvalvaag <jorgen.kvalvaag@nordicsemi.no>
@jorgenmk jorgenmk force-pushed the fix-conn-bridge-cdc-irq branch from ea71aa3 to 94ad3f3 Compare March 26, 2025 11:55
@jorgenmk jorgenmk removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Mar 26, 2025
Copy link
Contributor

@nordic-auko nordic-auko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jorgenmk jorgenmk merged commit aa4c8e2 into nrfconnect:main Mar 26, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a known bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants