Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app: conn_bridge: Reduce logging to save flash space #21161

Merged
merged 1 commit into from
Mar 27, 2025
Merged

app: conn_bridge: Reduce logging to save flash space #21161

merged 1 commit into from
Mar 27, 2025

Conversation

jorgenmk
Copy link
Contributor

Reduce logging to make app fit on thingy91x/nrf5340 flash.

@jorgenmk jorgenmk requested review from nordic-auko and a team as code owners March 26, 2025 11:19
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Mar 26, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Mar 26, 2025 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 3

Inputs:

Sources:

sdk-nrf: PR head: dc6e4c010ebb84fe4dc12a4f353510dc880d11d9

more details

sdk-nrf:

PR head: dc6e4c010ebb84fe4dc12a4f353510dc880d11d9
merge base: aa4c8e24d07063f2677724d95d56aee280d53ec0
target head (main): aa4c8e24d07063f2677724d95d56aee280d53ec0
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (2) 
applications
│  ├── connectivity_bridge
│  │  ├── boards
│  │  │  │ thingy91x_nrf5340_cpuapp.conf
scripts
│  │ quarantine.yaml

Outputs:

Toolchain

Version: 4ffa2202d5
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:4ffa2202d5_8bf7ca4353

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 29
  • ✅ Integration tests
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@github-actions GitHub Actions
Copy link

You can find the documentation preview for this PR here.

@jorgenmk jorgenmk force-pushed the fix-flash-space-bridge-t91x branch from a3128fc to b544c67 Compare March 26, 2025 13:18
@jorgenmk jorgenmk requested a review from a team as a code owner March 26, 2025 13:18
@jorgenmk jorgenmk added bugfix Fixes a known bug and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Mar 26, 2025
@github-actions GitHub Actions
Copy link

Since quarantine was modified, please make sure you are following the process described in Quarantine Process.

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Mar 26, 2025
@jorgenmk
app: conn_bridge: Reduce logging to save flash space
dc6e4c0 
Reduce logging to make app fit on thingy91x/nrf5340 flash.
Remove build from quarantine.

Signed-off-by: Jorgen Kvalvaag <jorgen.kvalvaag@nordicsemi.no>
@jorgenmk jorgenmk force-pushed the fix-flash-space-bridge-t91x branch from b544c67 to dc6e4c0 Compare March 26, 2025 13:34
nordic-auko
nordic-auko approved these changes Mar 26, 2025
View reviewed changes
Copy link
Contributor

@nordic-auko nordic-auko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jorgenmk jorgenmk removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Mar 26, 2025
moksanen
moksanen approved these changes Mar 27, 2025
View reviewed changes
Copy link
Contributor

@moksanen moksanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jorgenmk jorgenmk merged commit aec942e into nrfconnect:main Mar 27, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nordic-auko nordic-auko nordic-auko approved these changes

@bjda bjda bjda approved these changes

@moksanen moksanen moksanen approved these changes

Assignees
No one assigned
Labels
bugfix Fixes a known bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jorgenmk @NordicBuilder @nordic-auko @bjda @moksanen