Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esb: Fix timer shorts configuration for CONFIG_ESB_NEVER_DISABLE_TX #21164

Merged
merged 1 commit into from
Mar 27, 2025
Merged

esb: Fix timer shorts configuration for CONFIG_ESB_NEVER_DISABLE_TX #21164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions doc/nrf/protocols/esb/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,3 +338,5 @@ It changes the ESB driver's behavior.
If a packet is not acknowledged, the radio peripheral remains in TXIDLE state instead of TXDISABLE when transmission is pending.
Using this experimental feature can reduce transmission delay below 100 µs for a 32 bits (four bytes) payload.
However, this process consumes more energy, because the radio transmitter stage remains enabled when transmission is taking place.
In this mode, the :c:member:`esb_config.retransmit_delay` field specifies the delay between consecutive packet transmissions from the TX FIFO.
Depending on the reception processing time, a minimum value might be required.
10 changes: 10 additions & 0 deletions subsys/esb/esb.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,6 +420,16 @@ static void esb_fem_for_tx_set(bool ack)
nrf_timer_cc_set(esb_timer.p_reg, NRF_TIMER_CC_CHANNEL2, ramp_up);
}

if (IS_ENABLED(CONFIG_ESB_NEVER_DISABLE_TX)) {
uint32_t cc1 = nrfx_timer_capture_get(&esb_timer, NRF_TIMER_CC_CHANNEL1);
uint32_t cc2 = nrfx_timer_capture_get(&esb_timer, NRF_TIMER_CC_CHANNEL2);

if (cc1 > cc2) {
timer_shorts = NRF_TIMER_SHORT_COMPARE1_STOP_MASK;
timer_shorts |= NRF_TIMER_SHORT_COMPARE1_CLEAR_MASK;
}
}

nrf_timer_shorts_set(esb_timer.p_reg, timer_shorts);
}

Expand Down