applications: sdp: mspi: minor cleanup in RX #21177
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move parts of code to static inline functions. Optimize execution in RX path - no need to check `i` on every loop. Signed-off-by: Marcin Szymczyk <marcin.szymczyk@nordicsemi.no>
github-actions
bot
added
the
changelog-entry-required
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: e0f69e65d9c0b4e1db5e378cf93f7a85154bd829 more detailssdk-nrf:
Github labels
List of changed files detected by CI (2)Outputs:ToolchainVersion: 4ffa2202d5 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
|
You can find the documentation preview for this PR here. |
magp-nordic
reviewed
Mar 28, 2025
Comment on lines
+408
to
409
| uint32_t i = 1; | ||
| for (; i < hrt_xfer_params->xfer_data[HRT_FE_DATA].word_count; i++) { |
There was a problem hiding this comment.
I do not see i being used anywhere outside of this loop, so these lines can be merged:
Suggested change
| uint32_t i = 1; | |
| for (; i < hrt_xfer_params->xfer_data[HRT_FE_DATA].word_count; i++) { | |
| for (uint32_t i = 1; i < hrt_xfer_params->xfer_data[HRT_FE_DATA].word_count; i++) { |
|
Cleanups applied on other PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move parts of code to static inline functions.
Optimize execution in RX path - no need to check
ion every loop.