Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpsl: Increase default config for how often hfpll is calibrated #21211

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

martintv
Copy link
Contributor

It is a bit excessive to calibrate hfpll every 4s. Increasing to 60s to save power in the case where LFRC calibartion doesnt happen (when LFXO is used).

It is a bit excessive to calibrate hfpll every 4s.
Increasing to 60s to save power in the case where LFRC
calibartion doesnt happen (when LFXO is used).

Signed-off-by: Martin Tverdal <martin.tverdal@nordicsemi.no>
@martintv martintv requested a review from a team as a code owner March 28, 2025 11:36
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Mar 28, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Mar 28, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 2

Inputs:

Sources:

sdk-nrf: PR head: 40e21da5a88321d49e108b0837e03d8452201e9d

more details

sdk-nrf:

PR head: 40e21da5a88321d49e108b0837e03d8452201e9d
merge base: 94d394275d4028b52c4f8a087f56789d980c0a59
target head (main): 3227327fd085c7a56e7b28d74b40e764f5702a69
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (1)
subsys
│  ├── mpsl
│  │  ├── init
│  │  │  │ Kconfig

Outputs:

Toolchain

Version: 4ffa2202d5
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:4ffa2202d5_8bf7ca4353

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister - Skipped: Skipping Build & Test as it succeeded in a previous run: 1
  • ✅ Integration tests
    • ✅ test_ble_nrf_config
    • ✅ test-fw-nrfconnect-ble_samples - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-chip - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-rs - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-fem - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-thread - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-find-my - Skipped: Job was skipped as it succeeded in a previous run
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-tfm
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@hermabe hermabe requested a review from a team March 28, 2025 11:46
@hermabe
Copy link
Member

hermabe commented Mar 28, 2025

We should update the codeowners for these files. This has nothing to do with build system and should belong to owners of mpsl (ncs-dragoon).

@rugeGerritsen
Copy link
Contributor

We should update the codeowners for these files. This has nothing to do with build system and should belong to owners of mpsl (ncs-dragoon).

@nrfconnect/ncs-co-build-system, can we do something about this?

Copy link

You can find the documentation preview for this PR here.

@nordicjm
Copy link
Contributor

We should update the codeowners for these files. This has nothing to do with build system and should belong to owners of mpsl (ncs-dragoon).

No, it is correct that all Kconfig files are checked by build system to prevent the many mistakes/abuses/bad options that previously were unchecked

@hermabe hermabe merged commit 67750a2 into main Mar 31, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants