Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: location: Fix combining of cell and Wi-Fi methods #21350

Merged

Conversation

tokangas
Copy link
Contributor

@tokangas tokangas commented Apr 3, 2025

Fixed combining of cellular and Wi-Fi methods broken by commit 5e39c5f.

Jira: LRCS-110

Fixed combining of cellular and Wi-Fi methods broken by
commit 5e39c5f.

Signed-off-by: Tommi Kangas <tommi.kangas@nordicsemi.no>
@tokangas tokangas requested a review from a team as a code owner April 3, 2025 06:57
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Apr 3, 2025
@tokangas tokangas removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Apr 3, 2025
@tokangas tokangas added this to the 3.0.0 milestone Apr 3, 2025
@tokangas tokangas added the bugfix Fixes a known bug label Apr 3, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Apr 3, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 1

Inputs:

Sources:

sdk-nrf: PR head: ddef283be324e06ef2b0ad748ba719a7bd582eab

more details

sdk-nrf:

PR head: ddef283be324e06ef2b0ad748ba719a7bd582eab
merge base: e985a835e2a8cd34de767d5b1d4fe2ba9326dbba
target head (main): d99cc8e41850c64279235154dc7e3492adc54bba
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (1)
lib
│  ├── location
│  │  │ location_core.c

Outputs:

Toolchain

Version: 7dbe0e2658
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:7dbe0e2658_8bf7ca4353

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 228
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-nrf-iot_cloud
    • ✅ test-fw-nrfconnect-nrf-iot_mosh
    • ✅ test-fw-nrfconnect-nrf-iot_positioning
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@tokangas tokangas requested a review from jhirsi April 3, 2025 07:01
Copy link

github-actions bot commented Apr 3, 2025

You can find the documentation preview for this PR here.

@rlubos rlubos merged commit fde1f78 into nrfconnect:main Apr 3, 2025
18 checks passed
@tokangas tokangas deleted the location_lib_fix_wifi_cell_combine branch April 3, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a known bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants