Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: nrf_cloud: coap: improve thread safety #21369

Merged
merged 2 commits into from
Apr 7, 2025

Conversation

maxd-nordic
Copy link
Contributor

Properly guard functions using internal coap_client with mutexes.

@maxd-nordic maxd-nordic requested a review from a team as a code owner April 3, 2025 11:22
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Apr 3, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Apr 3, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 7

Inputs:

Sources:

sdk-nrf: PR head: a4d7cde684bb7f98d138f6d07dad64bb1b8ab933

more details

sdk-nrf:

PR head: a4d7cde684bb7f98d138f6d07dad64bb1b8ab933
merge base: 3237cd3472522131dbe1ab38ef759f7dce8d4bd0
target head (main): 652fdf4e751be71a3a0a2f3e70a58beb8ead19a0
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (1)
subsys
│  ├── net
│  │  ├── lib
│  │  │  ├── nrf_cloud
│  │  │  │  ├── coap
│  │  │  │  │  ├── src
│  │  │  │  │  │  │ nrf_cloud_coap_transport.c

Outputs:

Toolchain

Version: 7cbc0036f4
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:7cbc0036f4_8bf7ca4353

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 337
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-nrf-iot_cloud
    • ✅ test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • ✅ test-fw-nrfconnect-nrf-iot_thingy91
    • ✅ test-fw-nrfconnect-nrf-iot_mosh
    • ✅ test-fw-nrfconnect-nrf-iot_positioning
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@maxd-nordic maxd-nordic force-pushed the nrfcloud-coap-thread-safety branch from e258c6d to ae4d959 Compare April 3, 2025 11:34
@maxd-nordic maxd-nordic added the bugfix Fixes a known bug label Apr 3, 2025
@maxd-nordic maxd-nordic added this to the 3.0.0 milestone Apr 3, 2025
@maxd-nordic maxd-nordic force-pushed the nrfcloud-coap-thread-safety branch from ae4d959 to 27f0b83 Compare April 3, 2025 11:36
@maxd-nordic maxd-nordic force-pushed the nrfcloud-coap-thread-safety branch from 0beafd3 to ca59248 Compare April 4, 2025 11:44
@maxd-nordic maxd-nordic force-pushed the nrfcloud-coap-thread-safety branch from ca59248 to df76a2a Compare April 4, 2025 12:06
Properly guard functions using internal coap_client with mutexes.

Signed-off-by: Maximilian Deubel <maximilian.deubel@nordicsemi.no>
Cancel pending CoAP requests on timeout.
Otherwise, some other request might receive a response of a previous
one.

Signed-off-by: Maximilian Deubel <maximilian.deubel@nordicsemi.no>
@maxd-nordic maxd-nordic force-pushed the nrfcloud-coap-thread-safety branch from df76a2a to a4d7cde Compare April 7, 2025 10:33
@nordicjm nordicjm merged commit 2c64721 into nrfconnect:main Apr 7, 2025
13 checks passed
@maxd-nordic maxd-nordic added backport v3.0-branch and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants