Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

applications: nrf5340_audio: Use static address when privacy=n #21421

Merged
merged 1 commit into from
Apr 7, 2025
Merged

applications: nrf5340_audio: Use static address when privacy=n #21421

merged 1 commit into from
Apr 7, 2025
+8 −43

Conversation

alexsven
Copy link
Contributor

@alexsven alexsven commented Apr 4, 2025

  • Add BT_LE_ADV_OPT_USE_IDENTITY when BT_PRIVACY=n
  • This ensures a static address for debugging/testing purposes
  • Removed old method of reading out FICR to set static addr manually
  • OCT-3152

@alexsven alexsven added the bugfix Fixes a known bug label Apr 4, 2025
@alexsven alexsven added this to the 3.0.0 milestone Apr 4, 2025
@alexsven alexsven requested a review from a team as a code owner April 4, 2025 11:54
@alexsven alexsven requested review from koffes, rick1082 and gWacey April 4, 2025 11:54
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Apr 4, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Apr 4, 2025 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 8

Inputs:

Sources:

sdk-nrf: PR head: 35946879058aad271e6a26bd8b5188e4e9462b91

more details

sdk-nrf:

PR head: 35946879058aad271e6a26bd8b5188e4e9462b91
merge base: 280b1b7d4d8f47e64c4638db2069c86ddd467246
target head (main): 8fa8f2c7c8b5cc2f80b4f90d50ffa3db77460c03
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (2) 
applications
│  ├── nrf5340_audio
│  │  ├── src
│  │  │  ├── bluetooth
│  │  │  │  ├── bt_management
│  │  │  │  │  ├── advertising
│  │  │  │  │  │  │ bt_mgmt_adv.c
│  │  │  │  │  │ bt_mgmt.c

Outputs:

Toolchain

Version: 7cbc0036f4
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:7cbc0036f4_8bf7ca4353

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 33
  • ✅ Integration tests
    • ✅ test-sdk-audio
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-low-level
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2025 •
edited
Loading

You can find the documentation preview for this PR here.

@alexsven alexsven force-pushed the OCT-3152-public-address-not-working-for-broadcast-source branch 2 times, most recently from b846209 to d28e6a7 Compare April 4, 2025 15:18
@alexsven alexsven force-pushed the OCT-3152-public-address-not-working-for-broadcast-source branch from d28e6a7 to 14940e1 Compare April 7, 2025 08:21
@alexsven alexsven force-pushed the OCT-3152-public-address-not-working-for-broadcast-source branch from 14940e1 to 543befd Compare April 7, 2025 09:45
@alexsven alexsven requested a review from a team as a code owner April 7, 2025 09:45
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Apr 7, 2025
@alexsven alexsven added changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. backport v3.0-branch doc-required PR must not be merged without tech writer approval. and removed doc-required PR must not be merged without tech writer approval. labels Apr 7, 2025
@alexsven alexsven mentioned this pull request Apr 7, 2025
Open
29 tasks
@alexsven alexsven requested a review from koffes April 7, 2025 09:48
umapraseeda
umapraseeda requested changes Apr 7, 2025
View reviewed changes
Copy link
Contributor

@umapraseeda umapraseeda left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the changelog entry. I have added it here in the release notes for 3.0.0: #21339

@alexsven alexsven force-pushed the OCT-3152-public-address-not-working-for-broadcast-source branch from 543befd to 3594687 Compare April 7, 2025 10:50
@github-actions github-actions bot removed the doc-required PR must not be merged without tech writer approval. label Apr 7, 2025
@alexsven alexsven requested a review from umapraseeda April 7, 2025 10:50
@alexsven
applications: nrf5340_audio: Use static address when privacy=n
3594687 
- Add BT_LE_ADV_OPT_USE_IDENTITY when BT_PRIVACY=n
- This ensures a static address for debugging/testing purposes
- Removed old method of reading out FICR to set static addr manually
- OCT-3152

Signed-off-by: Alexander Svensen <alexander.svensen@nordicsemi.no>
@koffes koffes merged commit ef585d6 into nrfconnect:main Apr 7, 2025
14 checks passed
@NordicBuilder NordicBuilder mentioned this pull request Apr 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koffes koffes koffes approved these changes

@rick1082 rick1082 rick1082 approved these changes

@umapraseeda umapraseeda umapraseeda approved these changes

@gWacey gWacey Awaiting requested review from gWacey gWacey is a code owner automatically assigned from nrfconnect/ncs-audio

Assignees
No one assigned
Labels
backport v3.0-branch bugfix Fixes a known bug changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@alexsven @NordicBuilder @koffes @rick1082 @umapraseeda