MPSL flash sync (with SDC driver intact) #3067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
doc-required
eugmes
changed the title
eugmes
requested review from
anangl,
joerchan and
rugeGerritsen
as code owners
eugmes
changed the title
|
Hi, I've been running quite many Thread Certification tests on this PR and so far so good, no issues found. |
edmont
approved these changes
Oct 9, 2020
rugeGerritsen
requested changes
Oct 9, 2020
rugeGerritsen
removed
the
doc-required
joerchan
suggested changes
Oct 9, 2020
tomchy
approved these changes
Oct 9, 2020
|
@eugmes Please rebase your PR to fix the CI issue. |
|
@tomchy: The second commit has changed timings slightly. I would suggest rerunning the tests. |
|
@eugmes I've started CI while writing the first approval 🙂 |
joerchan
approved these changes
Oct 9, 2020
|
This and #3003 have passed CI. |
|
Thread Commissioning tests passed successfully with current changes. |
anangl
reviewed
Oct 9, 2020
Comment on lines
147
to
151
| uint32_t ret = mpsl_timeslot_session_open(timeslot_callback, | ||
| &_context.session_id); | ||
| MULTITHREADING_LOCK_RELEASE(); | ||
|
|
||
| if (ret < 0) { |
There was a problem hiding this comment.
How a uint32_t value could be < 0?
Add flash sync support for the soc_flash_nrf driver using MPSL timeslot API. Signed-off-by: Ievgenii Meshcheriakov <ievgenii.meshcheriakov@nordicsemi.no>
|
Squashed everything. |
anangl
approved these changes
Oct 9, 2020
|
The CI is green again |
rlubos
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds flash sync support for the soc_flash_nrf driver using MPSL timeslot API.
Ref: DRGN-14778
This is a version of #3003 with SDC flash driver intact.