Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kconfig: don't 'select' ZCBOR #1372

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
kconfig: don't 'select' ZCBOR
When an option depends on another option being set, its definition
should use 'depends on' - not 'select'.

Using 'select' introduces a two way dependency which makes
it impossible to express proper kconfig dependencies in some
cases.

See 'select pitfalls' chapter in zephyr documentation for details.

Ref: NCSDK-27818

Signed-off-by: Håkon Amundsen <haakon.amundsen@nordicsemi.no>
  • Loading branch information
hakonfam committed Jun 6, 2024
commit c2a804c91d36eb37130bc40dd684169483e0cef9
4 changes: 2 additions & 2 deletions nrf_rpc/Kconfig
Original file line number Diff line number Diff line change
@@ -14,8 +14,8 @@ if NRF_RPC
config NRF_RPC_CBOR
bool "Add CBOR layer"
default y
select ZCBOR
select ZCBOR_STOP_ON_ERROR
depends on ZCBOR
depends on ZCBOR_STOP_ON_ERROR
help
Adds API that helps use of CBOR library for data serialization.

Loading