-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry pick pts related fixes #2599
Merged
rlubos
merged 8 commits into
nrfconnect:main
from
alexsven:cherry-pick-PTS-related-fixes
Mar 11, 2025
Merged
Cherry pick pts related fixes #2599
rlubos
merged 8 commits into
nrfconnect:main
from
alexsven:cherry-pick-PTS-related-fixes
Mar 11, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4b51190
to
d43941f
Compare
Takes in use IS_ENABLED as preferred way of guarding Kconfig option for forcing OOB legacy, CONFIG_BT_SMP_OOB_LEGACY_PAIR_ONLY. It enables compiling guarded code get warning/errors and not link it if not used. If def macro is left in btp_handler structure to reduce code size when the config is not present. Signed-off-by: Evgenii Kosenko <Evgenii.Kosenko@silabs.com> (cherry picked from commit fed5561)
Takes in use IS_ENABLED as preferred way of guarding Kconfig option for enabling privacy, CONFIG_BT_PRIVACY. It enables compiling guarded code get warning/errors and not link it if not used. Signed-off-by: Evgenii Kosenko <Evgenii.Kosenko@silabs.com> (cherry picked from commit bf7dfc5)
Disabling extended advertising, CONFIG_BT_EXT_ADV, fails to compile cause references not guarded ext_adv variable when tester_gap_create_adv_instance is called. Fixes by taking in use IS_ENABLED as preferred way of guarding Kconfig option. It enables compiling guarded code to get warning/errors and not to link if not used. Signed-off-by: Evgenii Kosenko <Evgenii.Kosenko@silabs.com> (cherry picked from commit 0b2fbf9)
…lection Takes in use IS_ENABLED as preferred way of guarding Kconfig option for enabling legacy LE secure pairing, CONFIG_BT_SMP_SC_PAIR_ONLY. It enables compiling guarded code get warning/errors and not link it if not used. Signed-off-by: Evgenii Kosenko <Evgenii.Kosenko@silabs.com> (cherry picked from commit 1633f98)
Takes in use IS_ENABLED as preferred way of guarding Kconfig option for enabling periodic advertising api, CONFIG_BT_PER_ADV. It enables compiling guarded code get warning/errors and not link it if not used. Signed-off-by: Evgenii Kosenko <Evgenii.Kosenko@silabs.com> (cherry picked from commit d8f8dd4)
…ta_request CONFIG_BT_SMP_OOB_LEGACY_PAIR_ONLY disables all but legacy OOB pairing (including LE SC) and is not intended for enabling/disabling support for legacy OOB pairing. bt_le_oob_set_legacy_tk() depends on CONFIG_BT_SMP_SC_PAIR_ONLY so just use same check here. For BT_CONN_OOB_LE_SC only supported way to disable LE SC OOB is to force BT_SMP_OOB_LEGACY_PAIR_ONLY which disables all pairing except legacy OOB support. Signed-off-by: Szymon Janc <szymon.janc@codecoup.pl> (cherry picked from commit c20bd87)
…ronous - Add semaphore to make sure source is stopped before proceeding - This ensures source can be released after this command is finished Signed-off-by: Alexander Svensen <alexander.svensen@nordicsemi.no> (cherry picked from commit 6d19fc2)
- Make ext_adv and per_adv into arrays for multiple BIGs - Create bap_broadcast-source_setup_v2 command - Handles broadcast_id as an input Signed-off-by: Graham Wacey <graham.wacey@nordicsemi.no> Signed-off-by: Alexander Svensen <alexander.svensen@nordicsemi.no> (cherry picked from commit fb620ef) Signed-off-by: Alexander Svensen <alexander.svensen@nordicsemi.no>
d43941f
to
87da191
Compare
Frodevan
approved these changes
Mar 11, 2025
Thalley
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick fixes for PTS from upstream Zephyr