[nrf noup] drivers: flash: align handling reset pin to SDP MSPI #2652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magp-nordic
force-pushed
the
NRFX-7213-handle-reset-gpios-property
branch
2 times, most recently
from
1b3b3f2 to
14f5b98
Compare
Align handling reset pin to SDP MSPI so that it would work with nRF54L15 DK flash, which has RESET pin the same as one of data pins (D3). Signed-off-by: Magdalena Pastula <magdalena.pastula@nordicsemi.no>
magp-nordic
force-pushed
the
NRFX-7213-handle-reset-gpios-property
branch
from
14f5b98 to
cfe42d2
Compare
|
|
Closing, after discussion with @anangl we came to the conclusion that these changes are not needed, since reset gpio defined in dts should not overlay if any MSPI data pin. If it does, it should be handled internally in MSPI driver as pull-up or holding high state until QUAD mode is enabled in flash, which is the current solution in SDP MSPI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align handling reset pin to SDP MSPI so that it would work with nRF54L15 DK flash, which has RESET pin the same as one of data pins (D3).
Need changes from nrfconnect/sdk-nrf#21076 to work.