Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wifi: Upmerge 2 (fixes only) for nrf_wifi #2695

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

krish2718
Copy link
Contributor

Pull all nrf_wifi fixes.

manifest-pr-skip

based on #2519 will rebase once it's merged, this is raised to start testing early.

@krish2718 krish2718 added this to the ncs-3.0.0 milestone Apr 1, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Apr 1, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
nrf_wifi zephyrproject-rtos/nrf_wifi@f8dbe23 zephyrproject-rtos/nrf_wifi@8fd3cd7 (main) zephyrproject-rtos/nrf_wifi@f8dbe23c..8fd3cd7b

Additional metadata changed:

Name URL Submodules West cmds module.yml
nrf_wifi

DNM label due to: 1 project with metadata changes

Note: This message is automatically posted and updated by the Manifest GitHub Action.

Copy link
Contributor

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commits without sauce tag

@krish2718
Copy link
Contributor Author

Commits without sauce tag

Yes, saw that, was waiting for the dependent PR to be merged and will fix it during rebase, thanks.

@krish2718 krish2718 changed the title wifi: Upmerge 2 for nrf_wifi wifi: Upmerge 2 (fixes only) for nrf_wifi Apr 3, 2025
krish2718 and others added 5 commits April 3, 2025 23:15
…build"

This reverts commit 32c2e5b.

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
Gets the stats directly from RPU memory instead of command and event
exchange.

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
(cherry picked from commit 85179fbadff39858486dfcbb0a9132698d95f915)
…from memory

Instead of a command and event mechanism that relies on processors being
active (UMAC/LMAC) add a new command that reads from the RPU memory
directly for all stats, useful in debugging when processors are
crashed/non-functional.

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
(cherry picked from commit 0cf47478ee2f71cbeea8ae9505fe0bc8e43b9e61)
Add Kconfig in init command for maximum ps poll failures count
and stbc enable in HT.

Signed-off-by: Kapil Bhatt <kapil.bhatt@nordicsemi.no>
(cherry picked from commit a934af8f895b739b4c6f60c14e0bc52fa03948eb)
Support to configure swctrl1 as input or output for coexistence.

Signed-off-by: Murali Thokala <Murali.Thokala@nordicsemi.no>
(cherry picked from commit 03c5f5f083df4b595d7e9194a4cc99b69bbb6fac)
@krish2718 krish2718 force-pushed the stats_from_memory branch 2 times, most recently from 4589ed1 to 006cd2d Compare April 3, 2025 17:57
@krish2718 krish2718 removed the DNM label Apr 3, 2025
@krish2718
Copy link
Contributor Author

Removed DNM as metadata changes are expected.

Copy link

sonarqubecloud bot commented Apr 3, 2025

@krish2718 krish2718 removed the DNM label Apr 4, 2025
Comment on lines +189 to +195
config NRF70_SR_COEX_SWCTRL1_OUTPUT
int "Configure SWCTRIL1 as output"
default 0

config NRF70_SR_COEX_BT_GRANT_ACTIVE_LOW
int "Configure BT grant active low"
default 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing depends on?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed will check and fix in upstream will pull in a new PR

default y
help
Receive packets encoded with STBC (Space-Time Block Coding)
in HT (Wi-Fi4) mode.
endif # WIFI_NRF70
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newline

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed will check and fix in upstream will pull in a new PR

Copy link
Contributor

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with caveat that these issues are fixed upstream later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants