Skip to content

feat: Support for pending count with Adaptive lookback #2486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Apr 18, 2025

Conversation

RohanAshar
Copy link
Contributor

@RohanAshar RohanAshar commented Mar 20, 2025

Continuation of #2373

This adds the pending calculation in the daemon and emits the metric. Timeline is now maintained in the daemon. Currently uses the 1m value of pending metric. This will change once we have the monovertex starts sending the lag metric without the timeline calculation.

Follow Up Work:

  • Monovertex to send pending lag without the timeline calculation to daemon
  • Monovertex to call pending for only pod 0

@RohanAshar RohanAshar requested a review from kohlisid March 20, 2025 21:04
@kohlisid
Copy link
Contributor

#2487
PR for the lag reader changes! Adds the new impl but triggers it only for monovertex right now.
Once similar changes are made for pipeline, then we can switch both monovertex and pipeline to the new impl.
Requires clean up!
We can discuss if we want to break this down in parts and merge, or only merge when both are done!

Signed-off-by: RohanAshar <rohanashar1@gmail.com>
Signed-off-by: RohanAshar <rohanashar1@gmail.com>
Signed-off-by: RohanAshar <rohanashar1@gmail.com>
Signed-off-by: RohanAshar <rohanashar1@gmail.com>
Signed-off-by: RohanAshar <rohanashar1@gmail.com>
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 60.81081% with 29 lines in your changes missing coverage. Please review.

Project coverage is 70.01%. Comparing base (3c04495) to head (09844bc).

Files with missing lines Patch % Lines
pkg/mvtxdaemon/server/service/rater/rater.go 47.91% 18 Missing and 7 partials ⚠️
pkg/mvtxdaemon/server/service/rater/helper.go 87.50% 2 Missing and 1 partial ⚠️
pkg/mvtxdaemon/server/service/mvtx_service.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2486      +/-   ##
==========================================
- Coverage   70.10%   70.01%   -0.10%     
==========================================
  Files         391      391              
  Lines       58243    58268      +25     
==========================================
- Hits        40834    40799      -35     
- Misses      16310    16363      +53     
- Partials     1099     1106       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: RohanAshar <rohanashar1@gmail.com>
Signed-off-by: RohanAshar <rohanashar1@gmail.com>
@vigith vigith changed the title chore: Support for pending count with Adaptive lookback feat: Support for pending count with Adaptive lookback Apr 8, 2025
@vigith vigith requested a review from yhl25 April 10, 2025 16:19
@vigith vigith marked this pull request as ready for review April 10, 2025 16:19
@vigith vigith requested review from whynowy and vigith as code owners April 10, 2025 16:19
Signed-off-by: RohanAshar <rohanashar1@gmail.com>
Signed-off-by: RohanAshar <rohanashar1@gmail.com>
Signed-off-by: RohanAshar <rohanashar1@gmail.com>
Signed-off-by: RohanAshar <rohanashar1@gmail.com>
@vigith vigith enabled auto-merge (squash) April 18, 2025 18:21
@whynowy whynowy disabled auto-merge April 18, 2025 18:25
@whynowy whynowy merged commit cb6e6e6 into numaproj:main Apr 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants