Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade unicode-width to 0.2 #895

Merged
merged 1 commit into from
Mar 26, 2025
Merged

Conversation

KAAtheWiseGit
Copy link
Contributor

unicode-width has to bundle unicode codepoint tables, so it's quite large (1.5MB). They've recently released the version 0.2, which caused a split in Nushell dependencies between 0.1 and 0.2, doubling the size.

The main breaking change for unicode-width is that \n is now counted as having width 1 and not 0. But that shouldn't matter for reedline, since the menus which use it (columnar/IDE/list) work on lines.

@sholderbach
Copy link
Member

Sounds generally good to me, I remember that the changed semantics caused some serious churn for the tabled layouting.

@sholderbach sholderbach merged commit 476438e into nushell:main Mar 26, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants