feat(Calendar): add variant prop
#4800
Open
+2,690
−2,593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
HugoRCD
requested changes
Aug 21, 2025
Co-authored-by: Hugo Richard <hrichard206@gmail.com>
HugoRCD
approved these changes
Aug 27, 2025
benjamincanac
changed the title
variant prop
github-actions
bot
added
the
documentation
benjamincanac
requested changes
Sep 1, 2025
| /** | ||
| * @defaultValue 'solid' | ||
| */ | ||
| variant?: 'solid' | 'outline' | 'soft' | 'subtle' | 'ghost' |
There was a problem hiding this comment.
The variant should be dynamically typed based on the theme:
Suggested change
| variant?: 'solid' | 'outline' | 'soft' | 'subtle' | 'ghost' | |
| variant?: Calendar['variants']['variant'] |
benjamincanac
removed
the
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolves #4713
❓ Type of change
📚 Description
Adding additional styling options for the select state of the calendar - including Soft, Subtle, Outline and Ghost - as well as the previous default Solid.
Docs have been updated with this property.
📝 Checklist