feat(components)!: rename nullify
modifier to nullable
and add optional
#4838
+92
β23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
Resolves: N/A
β Type of change
π Description
This mainly focuses on using these components in forms with validation libraries.
Considering that most validation libraries refers to value that are
T | null
asnullable
I decided to rename the modifier (taking advantage of the major), while also adding anoptional
modifier to acceptundefined
.Currently upstream's
NumberFieldRoot
only acceptoptional
values but notnullable
ones. At first I though about a type inconsistency but noticed a strange pattern in tests when I was forcing it, decided to only implementoptional
for now.What other components might take advantage of this other than
UInput
,UTextarea
andUInputNumber
?π Checklist