Instead of defining the destructor inline, provide its implementation… #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krajunv
force-pushed
the
fix-vtable-errors
branch
from
341e40d to
40a11f3
Compare
zlatinski
reviewed
Mar 18, 2025
| +++ b/common/libs/VkCodecUtils/VkImageResource.h | ||
| @@ -113,7 +113,7 @@ private: | ||
|
|
||
| void Destroy(); |
There was a problem hiding this comment.
I guess, we don't need this patch submitted here.
Otherwise, the change looks good to me.
… in a separate source file to make GCC 13 happy in release mode. Also fix other compilation errors in release mode. Signed-off-by: Raju Konda <kraju@nvidia.com>
krajunv
force-pushed
the
fix-vtable-errors
branch
from
40a11f3 to
bc4a939
Compare
zlatinski
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… in a separate source file to make GCC 13 happy in release mode.
Also fix other compilation errors in release mode.