Promote indexed merkle map to standard API #2114
Open
+15
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The current API has a subtle gotcha that I think should be mitigated. The map 'commitment' consists of two field elements: root and length. It's easy to miss the length and only check for the root. They should be combined in some way so that you include/check against both fields by default. |
|
@mitschabaude I'm curious - is there actually a collision risk with trees of different lengths? Or else why would we need to include the tree length? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This API is tested and documented, (more).
It seems ready to leave experimental, to me. If not, what do we need to do?