Config file

[burnout87]

No description provided.

[burnout87]

With this PR the following changes are introduced:

• config using FlaskDynaconf and passing those to the NotebookAdapter init, the file settings.toml is used to load the config
• check the file size before download

The config values for the init of the NotebookAdapter are currently passed only within the service module, do they have to be passed also elsewhere (eg ontology) @dsavchenko @volodymyrss ?

[dsavchenko]

The config file would be useful also to

• set the Sentry URL (currently via env var),
• set ontology path (it's used in deploy now, but will be needed in context of Support for multiline parameter definitions. Basic type annotations. #155 to get parameter type from annotation)

[burnout87]

* set ontology path (it's used in deploy now, but will be needed in context of [Support for multiline parameter definitions. Basic type annotations. #155](https://github.com/oda-hub/nb2workflow/pull/155) to get parameter type from annotation)

I now extract the path from the toml file for the deploy module, I guess the analogous approach should be implemented within galaxy ?

[dsavchenko]

Some suggestions on config structure.

Also, it would be good to have an ability to set the path to the config file in cli commands.
As before, I suggest using --settings for file path and rename the arg used to set config options directly from cli (and add it to other cli then). Alternatively, --settings_path is aalso ok

[dsavchenko]

These configs belong not only to service module. Probably better to have some separate blocks, e.g. [global] and [service] ?

[burnout87]

so, basically only host an port are specific for the service?

[dsavchenko]

Why "default" in the block name? Does it have any special meaning?

[burnout87]

It is needed when using the FlaskDynaConf, extension of DynaConf specific for Flask

https://www.dynaconf.com/flask/#settings-files

It needs to have an environment associated to that configuration, and default is the default

[burnout87]

Some suggestions on config structure.

Alternatively, --settings_path is aalso ok

This would be mainly used for the service, correct?

[dsavchenko]

This would be mainly used for the service, correct?

Mainly used: yes. But we need the ability to set the path to the config file in the whatever module that uses this config

[burnout87]

The number of changes to be introduced with the config file are far more than what I expected, and requires some more discussions.

I am going to split this PR in the two, where the first only tackles the "max size download" matter.

[volodymyrss]

@burnout87 it's still waiting in requested changes. Do you want to complete this? If it is still needed?

[burnout87]

@burnout87 it's still waiting in requested changes. Do you want to complete this? If it is still needed?

It requires a number of changes that should perhaps be discussed. Also, it'll take some time, so it has to be decided how much priority this actually has.