[GEN-2222]: add instrumentation-rule for code attributes #2239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ommended/verbose lists
BenElferink
requested review from
blumamir and
alonkeyval
and removed request for
blumamir
alonkeyval
reviewed
Jan 16, 2025
| import { SVG } from '@/assets'; | ||
| import theme from '@/styles/theme'; | ||
|
|
||
| export const CodeAttributesIcon: SVG = ({ size = 16, fill = theme.text.info, rotate = 0, onClick }) => { |
There was a problem hiding this comment.
Where did this icon come from?
There was a problem hiding this comment.
From Figma under "Design System" ---> icons
This one:
…ions and add tooltips to navigation buttons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following-up with a UI update in response to PR #2230
This pull request introduces the
CodeAttributesfeature to the instrumentation rules in the frontend. The changes span across multiple files, including model definitions, GraphQL schema, service functions, and the web application interface. The most important changes are summarized below:Model and Schema Updates:
CodeAttributesandCodeAttributesInputtypes to themodels_gen.gofile and integrated them into theInstrumentationRuleandInstrumentationRuleInputstructs. [1] [2] [3]CodeAttributesandCodeAttributesInputin theInstrumentationRuleandInstrumentationRuleInputtypes. [1] [2] [3]Service Layer Changes:
ListInstrumentationRules,UpdateInstrumentationRule, andCreateInstrumentationRulefunctions to handle the newCodeAttributesfield. [1] [2] [3] [4] [5] [6]Web Application Updates:
CodeAttributesIconcomponent and exported it for use in the application. [1] [2]ActionModalcomponent to autofocus only when no action type is selected.build-drawer-itemfunction to includecodeAttributesin the drawer item construction. [1] [2]CodeAttributescomponent for the rule form body, allowing users to select which code attributes to collect. [1] [2] [3]PayloadCollectioncomponent to handle cases wherepayloadCollectionmight be undefined.RuleModalcomponent to start with no pre-selected rule option.