- Updated all IGenericEntity implementations to support 'no-directory…

…' deployments
oleg-shilo · Apr 14, 2018 · 38453cc · 38453cc
1 parent 95b3c6a
commit 38453cc
Show file tree

Hide file tree

Showing 9 changed files with 38 additions and 11 deletions.
diff --git a/Source/src/WixSharp/Certificate.cs b/Source/src/WixSharp/Certificate.cs
@@ -234,7 +234,11 @@ public void Process(ProcessingContext context)
 
             XElement component = this.CreateParentComponent();
             component.Add(this.ToXElement(WixExtension.IIs, "Certificate"));
-            context.XParent.FindFirst("Component").Parent?.Add(component);
+
+            XElement bestParent = context.XParent.FindFirstComponentParent() ??
+                                  context.XParent.FistProgramFilesDir();
+
+            bestParent.Add(component);
 
             MapComponentToFeatures(component.Attribute("Id")?.Value, ActualFeatures, context);
         }

diff --git a/Source/src/WixSharp/EnvironmentVariable.cs b/Source/src/WixSharp/EnvironmentVariable.cs
@@ -172,10 +172,10 @@ public void Process(ProcessingContext context)
                          .AddAttributes(Condition.Attributes));
             }
 
-            var parent = context.XParent.FindFirstComponentParent() ??
-                         context.XParent.FindLastDirectory();
+            XElement bestParent = context.XParent.FindFirstComponentParent() ??
+                                  context.XParent.FistProgramFilesDir();
 
-            parent?.Add(component);
+            bestParent.Add(component);
 
             MapComponentToFeatures(component.Attr("Id"), ActualFeatures, context);
         }

diff --git a/Source/src/WixSharp/IniFile.cs b/Source/src/WixSharp/IniFile.cs
@@ -525,7 +525,11 @@ public void Process(ProcessingContext context)
         {
             XElement component = this.CreateParentComponent();
             component.Add(this.ToXElement("IniFile"));
-            context.XParent.FindFirst("Component").Parent?.Add(component);
+
+            XElement bestParent = context.XParent.FindFirstComponentParent() ??
+                                  context.XParent.FistProgramFilesDir();
+
+            bestParent.Add(component);
 
             MapComponentToFeatures(component.Attr("Id"), ActualFeatures, context);
         }

diff --git a/Source/src/WixSharp/RemoveRegistryKey.cs b/Source/src/WixSharp/RemoveRegistryKey.cs
@@ -275,7 +275,11 @@ public void Process(ProcessingContext context)
         {
             XElement component = this.CreateParentComponent();
             component.Add(this.ToXElement("RemoveRegistryKey"));
-            context.XParent.FindFirst("Component").Parent?.Add(component);
+
+            XElement bestParent = context.XParent.FindFirstComponentParent() ??
+                                  context.XParent.FistProgramFilesDir();
+
+            bestParent.Add(component);
 
             MapComponentToFeatures(component.Attr("Id"), ActualFeatures, context);
         }

diff --git a/Source/src/WixSharp/RemoveRegistryValue.cs b/Source/src/WixSharp/RemoveRegistryValue.cs
@@ -263,7 +263,11 @@ public void Process(ProcessingContext context)
         {
             XElement component = this.CreateParentComponent();
             component.Add(this.ToXElement("RemoveRegistryValue"));
-            context.XParent.FindFirst("Component").Parent?.Add(component);
+
+            XElement bestParent = context.XParent.FindFirstComponentParent() ??
+                                  context.XParent.FistProgramFilesDir();
+
+            bestParent.Add(component);
 
             MapComponentToFeatures(component.Attr("Id"), ActualFeatures, context);
         }

diff --git a/Source/src/WixSharp/SqlDatabase.cs b/Source/src/WixSharp/SqlDatabase.cs
@@ -283,7 +283,10 @@ public void Process(ProcessingContext context)
                         item.Process(newContext);
                 }
 
-                context.XParent.FindFirst("Component").Parent?.Add(component);
+                XElement bestParent = context.XParent.FindFirstComponentParent() ??
+                                      context.XParent.FistProgramFilesDir();
+
+                bestParent.Add(component);
                 MapComponentToFeatures(component.Attr("Id"), ActualFeatures, context);
             }
             else

diff --git a/Source/src/WixSharp/SqlScript.cs b/Source/src/WixSharp/SqlScript.cs
@@ -765,7 +765,11 @@ public void Process(ProcessingContext context)
                 XElement sqlScript = this.ToXElement(WixExtension.Sql, "SqlScript");
                 component.Add(sqlScript);
 
-                context.XParent.FindFirst("Component").Parent?.Add(component);
+                XElement bestParent = context.XParent.FindFirstComponentParent() ??
+                                      context.XParent.FistProgramFilesDir();
+
+                bestParent.Add(component);
+
                 MapComponentToFeatures(component.Attr("Id"), ActualFeatures, context);
             }
             else

diff --git a/Source/src/WixSharp/SqlString.cs b/Source/src/WixSharp/SqlString.cs
@@ -435,7 +435,11 @@ public void Process(ProcessingContext context)
                 XElement sqlString = this.ToXElement(WixExtension.Sql, "SqlString");
                 component.Add(sqlString);
 
-                context.XParent.FindFirst("Component").Parent?.Add(component);
+                XElement bestParent = context.XParent.FindFirstComponentParent() ??
+                                  context.XParent.FistProgramFilesDir();
+
+                bestParent.Add(component);
+
                 MapComponentToFeatures(component.Attr("Id"), ActualFeatures, context);
             }
             else

diff --git a/Source/src/WixSharp/User.cs b/Source/src/WixSharp/User.cs
@@ -263,7 +263,7 @@ public void Process(ProcessingContext context)
                 XElement component = this.CreateParentComponent();
                 component.Add(this.ToXElement(WixExtension.Util, "User"));
 
-                XElement bestParent = context.XParent.FindFirst("Component")?.Parent ??
+                XElement bestParent = context.XParent.FindFirstComponentParent() ??
                                       context.XParent.FistProgramFilesDir();
 
                 bestParent.Add(component);