-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCLomatic #1335] Add tests for device_new and device_delete #477
[SYCLomatic #1335] Add tests for device_new and device_delete #477
Conversation
Signed-off-by: Matthew Michel <matthew.michel@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mmichel11 CI test failed for this PR:
Pls take a look. |
I believe this is occurring because the CI was ran before the corresponding SYCLomatic PR was merged. The test is passing on my side. Could you trigger a rerun of this CI job? I do not seem to have permission to rerun CI (without making a new commit). |
@tomflinda I have triggered a CI rerun with an empty commit. The tests now pass since the bugfix I provided has been merged into the main SYCLomatic repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds test for
dpct::device_new
anddpct::device_delete
and complements the fixes provided in SYCLomatic #1335. The test cases will not pass until the SYCLomatic PR is merged.All three implementations of
dpct::device_new
are tested in this PR.