Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCLomatic] Add support for cuGetErrorName #2618

Open
wants to merge 4 commits into
base: SYCLomatic
Choose a base branch
from
Open

[SYCLomatic] Add support for cuGetErrorName #2618

wants to merge 4 commits into from

Conversation

the-slow-one
Copy link
Collaborator

As SYCL has exception-based error handling, cuGetErrorName is replaced with a dummy method from DPCT with a suggestion to replace the dummy method based on the requirement.

Signed-off-by: Deepak Raj H R

@the-slow-one the-slow-one requested a review from a team as a code owner January 15, 2025 15:34
intwanghao
intwanghao approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@intwanghao intwanghao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TejaX-Alaghari TejaX-Alaghari TejaX-Alaghari approved these changes

@intwanghao intwanghao intwanghao approved these changes

@ShengchenJ ShengchenJ ShengchenJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@the-slow-one @ShengchenJ @intwanghao @TejaX-Alaghari