Support for Sorting Drivers based on the devices provided #259
Conversation
- Added support for reporting drivers sorted based on the types of
devices returned.
- By default, drivers will be sorted such that the ordering will be:
- Drivers with Discrete GPUs only
- Drivers with Discrete and Integrated GPUs
- Drivers with Integrated GPUs
- Drivers with Mixed Devices Types (ie GPU + NPU)
- Drivers with Non GPU Devices Only
- If ZE_ENABLE_PCI_ID_DEVICE_ORDER is set, then the following ordering
is provided:
- Drivers with Integrated GPUs
- Drivers with Discrete and Integrated GPUs
- Drivers with Discrete GPUs only
- Drivers with Mixed Devices Types (ie GPU + NPU)
- Drivers with Non GPU Devices Only
- Expanded the zello_world sample to test both init paths for easy
prototyping.
Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
nrspruit
force-pushed
the
driver_sorting
branch
from
41e098f to
5a4efe4
Compare
samples/zello_world/zello_world.cpp
Outdated
| @@ -61,13 +62,22 @@ int main( int argc, char *argv[] ) | |||
| { | |||
| tracing_runtime_enabled = true; | |||
| } | |||
| if( argparse( argc, argv, "-legacy", "--enable_legacy_init" ) ) | |||
There was a problem hiding this comment.
minor suggestion, rename -legacy to -legacy_init as many other future options may be legacy in nature.
| @@ -26,6 +26,18 @@ | |||
| #include "spdlog/spdlog.h" | |||
| namespace loader | |||
| { | |||
| /////////////////////////////////////////////////////////////////////////////// | |||
There was a problem hiding this comment.
Optional, put a comment here that the ordering here is critical and/or used by sorting algorithms, so care should be used when adding. Also this should NOT be used anyplace else so we can modify this ENUM (I see this is internal so should be fine, but let's ensure it stays internal) without ABI issues.
There was a problem hiding this comment.
This remains internal and is not used outside of the loader nor released. I updated the comment accordingly.
| ZEL_DRIVER_TYPE_DISCRETE_GPU= 0, ///< The driver has Discrete GPUs only | ||
| ZEL_DRIVER_TYPE_GPU = 1, ///< The driver has Heterogenous GPU types |
There was a problem hiding this comment.
I see that iGPU can be assumed as slower than dGPU but why assuming that dGPU only driver is better than dGPU + iGPU ?
There was a problem hiding this comment.
This is an assumption based on an arch review. This is not guaranteed to always be true which is why customers should always ensure the right device is being used in their workloads and not always assume device 0 is the best.
source/loader/ze_loader.cpp
Outdated
| @@ -135,6 +135,47 @@ namespace loader | |||
| return flags_value; | |||
| } | |||
|
|
|||
| bool driverSortComparitor(const driver_t &a, const driver_t &b) { | |||
| bool pciOrderingRequested = getenv_tobool( "ZE_ENABLE_PCI_ID_DEVICE_ORDER" ); | |||
There was a problem hiding this comment.
in case of ZE_ENABLE_PCI_ID_DEVICE_ORDER set I believe that all runtimes should also respect the flag and expose lowest pci id first, so we can store pci_id of first device of each driver and the sort by that
There was a problem hiding this comment.
good point, I can remove the redundant setting and set in the first call.
There was a problem hiding this comment.
Fixed in latest, the comparator function now reads the driver's pci device order setting such that the env is only read one time and then the value is set for all drivers.
Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
nrspruit
force-pushed
the
driver_sorting
branch
from
db1ffb7 to
a0b4cdb
Compare
Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
Added support for reporting drivers sorted based on the types of devices returned.
By default, drivers will be sorted such that the ordering will be:
If ZE_ENABLE_PCI_ID_DEVICE_ORDER is set, then the following ordering is provided:
Expanded the zello_world sample to test both init paths for easy prototyping.