Tweak layout #44
Merged
Tweak layout #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phyrog
force-pushed
the
improve_users_and_organizations_page
branch
5 times, most recently
from
f6a8f2d to
ec5e881
Compare
phyrog
force-pushed
the
improve_users_and_organizations_page
branch
2 times, most recently
from
eab7cbe to
fe2233f
Compare
added 12 commits
January 27, 2017 13:47
phyrog
force-pushed
the
improve_users_and_organizations_page
branch
from
496f279 to
139bc14
Compare
eugenk
requested changes
Jan 27, 2017
| @@ -37,6 +37,7 @@ | |||
| "ember-cli-emblem": "0.8.2-beta.2", | |||
| "ember-cli-eslint": "3.0.2", | |||
| "ember-cli-foundation-6-sass": "0.0.18", | |||
| "ember-cli-gravatar": "3.8.0", | |||
There was a problem hiding this comment.
Don't we need to whitelist gravatar.com in the CSP?
| = if repo.publicAccess | ||
| = search-result 'unlock-alt' repo.id 'organizationalUnit.repository.show' repo.owner.id repo.repoId | ||
| p.help-text = repo.description | ||
| span.label = repo.contentType |
There was a problem hiding this comment.
This should be moved into a partial. Maybe in another issue, but it should be done.
eugenk
approved these changes
Jan 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves on a couple of layout points:
User/organization page
This adds some more info on the users/organization pages. Since this needs the models from #19, it is currently based on that, but will be rebased on master once #19 is merged.
Example of a users page using gravatar:
Example of an organization page:
Top bar
The
+Symbol is now a dropdown menu instead of a single link to theNew repositorypage. This is not very useful now, but as soon as we create aNew Organizationpage, we can add a link there.This dropdown menu layout will also be used for the user menu item, once we implement it.