-
Notifications
You must be signed in to change notification settings - Fork 278
new chatqna readme template #1755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new chatqna readme template #1755
Conversation
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
for more information, see https://pre-commit.ci
Signed-off-by: Srinarayan Srikanthan <srinarayan.srikanthan@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am ok with the content, just think shall we have a script to do all instructions in the readme rather than running them one by one manually in the shell?
Please fix the preci issue, https://results.pre-commit.ci/run/github/775149161/1743735950.uNMP0jlnTmC6WssCEYdqXQ |
Hi @srinarayan-srikanthan could you please resolve the comments? Thanks. |
@XinyaoWa please help review the FaqGen related content, thanks. |
Hi Sri, FagGen is merged into ChatQnA. FYI, here is the issue to be resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Signed-off-by: Srinarayan Srikanthan <srinarayan.srikanthan@intel.com>
Signed-off-by: Srinarayan Srikanthan <srinarayan.srikanthan@intel.com>
for more information, see https://pre-commit.ci
Both Do we need the |
what is the redundancy you are talking about @poussa ? |
please fix pre-commit issue and comments. |
Shall FagGen be mentioned in this document? FagGen has been merged in ChatQnA |
resolve the conflict
for more information, see https://pre-commit.ci
thank you for review. we had fixed it in one commit, but it seems come back again. fix it again just now. |
fix the layout error and address #1755 Monitoring and Tracing link
Description
New chatqna master readme and xeon readme.
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as
n/a
.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
NA
Tests
Describe the tests that you ran to verify your changes.