Fix security issue #1884
Open
Fix security issue #1884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
.github/workflows/_helm-e2e.yml
Outdated
Comment on lines
137
to
138
| AgentQnA,AudioQnA,AvatarChatbot,ChatQnA,CodeGen,CodeTrans,DBQnA,DocIndexRetriever,DocSum,EdgeCraftRAG,GraphRAG,InstructionTuning,MultimodalQnA,ProductivitySuite,RerankFinetuning,SearchQnA,Text2Image,Translation,VideoQnA,VisualQnA,WorkflowExecAgent) | ||
| echo "Valid example input: ${{ inputs.example }}" |
There was a problem hiding this comment.
The input is being converted to lowercase while the allowed values in the case pattern remain in mixed case, which may cause valid inputs to be rejected. Consider updating the allowed case patterns to lowercase or removing the lowercase conversion.
Suggested change
| AgentQnA,AudioQnA,AvatarChatbot,ChatQnA,CodeGen,CodeTrans,DBQnA,DocIndexRetriever,DocSum,EdgeCraftRAG,GraphRAG,InstructionTuning,MultimodalQnA,ProductivitySuite,RerankFinetuning,SearchQnA,Text2Image,Translation,VideoQnA,VisualQnA,WorkflowExecAgent) | |
| echo "Valid example input: ${{ inputs.example }}" | |
| agentqna,audioqna,avatarchatbot,chatqna,codegen,codetrans,dbqna,docindexretriever,docsum,edgecraftrag,graphrag,instructiontuning,multimodalqna,productivitysuite,rerankfinetuning,searchqna,text2image,translation,videoqna,visualqna,workflowexecagent) | |
| echo "Valid example input: ${{ inputs.example,, }}" |
Copilot uses AI. Check for mistakes.
chensuyue
reviewed
Apr 25, 2025
ZePan110
force-pushed
the
FixSEC
branch
4 times, most recently
from
cd20b2f to
998989d
Compare
Signed-off-by: ZePan110 <ze.pan@intel.com>
…ing/32 Signed-off-by: ZePan110 <ze.pan@intel.com>
chensuyue
reviewed
Apr 25, 2025
| folders=($(find . -maxdepth 1 -type d ! -name ".*" -printf "%f\n" | tr '[:upper:]' '[:lower:]')) | ||
| echo "folders: ${folders[@]}" | ||
| echo "example: ${{ inputs.example }}" | ||
| example_lower=$(echo "CodeGen" | tr '[:upper:]' '[:lower:]') |
There was a problem hiding this comment.
Why CodeGen here? Test code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The summary of the proposed changes as long as the relevant motivation and context.
Issues
https://github.com/opea-project/GenAIExamples/security/code-scanning/30
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
https://github.com/opea-project/GenAIExamples/actions/runs/14658733798