Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support yaml in blob, file, and http syncs #1522

Merged
merged 16 commits into from
Jan 28, 2025
Merged

feat: support yaml in blob, file, and http syncs #1522

merged 16 commits into from
Jan 28, 2025

Conversation

beeme1mr
Copy link
Member

@beeme1mr beeme1mr commented Jan 17, 2025 •
edited
Loading

This PR

  • adds support for yaml in blog syncs
  • rejects non-200 responses in the http sync

Related Issues

Fixes #1512

How to test

make test or make test-core

@beeme1mr
support yaml in blog syncs
6ea340c 
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
@beeme1mr beeme1mr requested a review from a team as a code owner January 17, 2025 16:23
@beeme1mr beeme1mr linked an issue Jan 17, 2025 that may be closed by this pull request
[BUG] inconsistent yaml support from file:// vs s3:// #1512
Closed
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jan 17, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 17, 2025 •
edited
Loading

✅ Deploy Preview for polite-licorice-3db33c canceled.

Name Link
🔨 Latest commit 5460a61
🔍 Latest deploy log https://app.netlify.com/sites/polite-licorice-3db33c/deploys/679917913439170008158aeb

@beeme1mr
fix lint issues
247b1ab 
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
@beeme1mr beeme1mr changed the title fix: support yaml in blog syncs fix: support yaml in blob syncs Jan 17, 2025
@beeme1mr
fix lint issues
4bcafae 
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
aepfli
aepfli approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@aepfli aepfli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, i share your thoughts about the breaking change, but i added a suggestion in the comment

austindrenski
austindrenski approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@austindrenski austindrenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for implementing this!

toddbaert
toddbaert approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @beeme1mr . I merged main to fix some conflicts.

I'll let you choose if you consider this "decided".

toddbaert and others added 2 commits January 20, 2025 15:49
@toddbaert
fixup: conflicts
0e75d5f 
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
@beeme1mr
add media type detection to file and http syncs
b642d59 
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jan 23, 2025
@beeme1mr
fix lint issues
170176c 
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
@beeme1mr
format files
9244e27 
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
@beeme1mr beeme1mr changed the title fix: support yaml in blob syncs feat: support yaml in blob, file, and http syncs Jan 23, 2025
austindrenski
austindrenski approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@austindrenski austindrenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only had time to skim through tonight, but everything looks to be in order. The convert to json tests are a nice addition and case coverage looks thorough!

@beeme1mr
fix lint issues
fc0d87c 
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
@beeme1mr
update docs for consistency
59b7a43 
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
@beeme1mr
error on non-200 status codes
7f0bbdc 
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
@beeme1mr
improve examples in docs
566b209 
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
@beeme1mr
fix tests
82dc01b 
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
@beeme1mr
fix test
0df927c 
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
@beeme1mr
Merge branch 'main' into 1512-bug-inconsistent-yaml-support-from-file…
c87c933 
…-vs-s3

Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
@beeme1mr
run go mod tidy
0c46a9e 
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
@beeme1mr
Merge branch 'main' into 1512-bug-inconsistent-yaml-support-from-file…
5460a61 
…-vs-s3
@beeme1mr beeme1mr merged commit 76d673a into main Jan 28, 2025
13 of 15 checks passed
@beeme1mr beeme1mr deleted the 1512-bug-inconsistent-yaml-support-from-file-vs-s3 branch January 28, 2025 17:53
@github-actions github-actions bot mentioned this pull request Jan 28, 2025
Merged
beeme1mr pushed a commit that referenced this pull request Jan 31, 2025
@github-actions
chore: release main (#1527)
a444b74 
🤖 I have created a release *beep* *boop*
---


<details><summary>flagd: 0.12.0</summary>

##
[0.12.0](flagd/v0.11.8...flagd/v0.12.0)
(2025-01-31)


### ⚠ BREAKING CHANGES

* flagSetMetadata in OFREP/ResolveAll, core refactors
([#1540](#1540))

### 🐛 Bug Fixes

* **deps:** update module
buf.build/gen/go/open-feature/flagd/connectrpc/go to
v1.18.1-20250127221518-be6d1143b690.1
([#1535](#1535))
([d5ec921](d5ec921))
* **deps:** update module buf.build/gen/go/open-feature/flagd/grpc/go to
v1.5.1-20250127221518-be6d1143b690.2
([#1536](#1536))
([e23060f](e23060f))
* **deps:** update module
buf.build/gen/go/open-feature/flagd/protocolbuffers/go to
v1.36.4-20241220192239-696330adaff0.1
([#1529](#1529))
([8881a80](8881a80))
* **deps:** update module
buf.build/gen/go/open-feature/flagd/protocolbuffers/go to
v1.36.4-20250127221518-be6d1143b690.1
([#1537](#1537))
([f74207b](f74207b))
* **deps:** update module github.com/open-feature/flagd/core to v0.10.8
([#1526](#1526))
([fbf2ed5](fbf2ed5))
* **deps:** update module google.golang.org/grpc to v1.70.0
([#1528](#1528))
([79b2b0a](79b2b0a))


### ✨ New Features

* flagSetMetadata in OFREP/ResolveAll, core refactors
([#1540](#1540))
([b49abf9](b49abf9))
</details>

<details><summary>flagd-proxy: 0.7.0</summary>

##
[0.7.0](flagd-proxy/v0.6.11...flagd-proxy/v0.7.0)
(2025-01-31)


### ⚠ BREAKING CHANGES

* flagSetMetadata in OFREP/ResolveAll, core refactors
([#1540](#1540))

### 🐛 Bug Fixes

* **deps:** update module buf.build/gen/go/open-feature/flagd/grpc/go to
v1.5.1-20250127221518-be6d1143b690.2
([#1536](#1536))
([e23060f](e23060f))
* **deps:** update module
buf.build/gen/go/open-feature/flagd/protocolbuffers/go to
v1.36.4-20241220192239-696330adaff0.1
([#1529](#1529))
([8881a80](8881a80))
* **deps:** update module
buf.build/gen/go/open-feature/flagd/protocolbuffers/go to
v1.36.4-20250127221518-be6d1143b690.1
([#1537](#1537))
([f74207b](f74207b))
* **deps:** update module github.com/open-feature/flagd/core to v0.10.8
([#1526](#1526))
([fbf2ed5](fbf2ed5))
* **deps:** update module google.golang.org/grpc to v1.70.0
([#1528](#1528))
([79b2b0a](79b2b0a))


### ✨ New Features

* flagSetMetadata in OFREP/ResolveAll, core refactors
([#1540](#1540))
([b49abf9](b49abf9))
</details>

<details><summary>core: 0.11.0</summary>

##
[0.11.0](core/v0.10.8...core/v0.11.0)
(2025-01-31)


### ⚠ BREAKING CHANGES

* flagSetMetadata in OFREP/ResolveAll, core refactors
([#1540](#1540))

### 🐛 Bug Fixes

* **deps:** update github.com/open-feature/flagd-schemas digest to
bb76343 ([#1534](#1534))
([8303353](8303353))
* **deps:** update golang.org/x/exp digest to 3edf0e9
([#1538](#1538))
([7a06567](7a06567))
* **deps:** update golang.org/x/exp digest to e0ece0d
([#1539](#1539))
([4281c6e](4281c6e))
* **deps:** update module buf.build/gen/go/open-feature/flagd/grpc/go to
v1.5.1-20250127221518-be6d1143b690.2
([#1536](#1536))
([e23060f](e23060f))
* **deps:** update module
buf.build/gen/go/open-feature/flagd/protocolbuffers/go to
v1.36.4-20241220192239-696330adaff0.1
([#1529](#1529))
([8881a80](8881a80))
* **deps:** update module
buf.build/gen/go/open-feature/flagd/protocolbuffers/go to
v1.36.4-20250127221518-be6d1143b690.1
([#1537](#1537))
([f74207b](f74207b))
* **deps:** update module google.golang.org/grpc to v1.70.0
([#1528](#1528))
([79b2b0a](79b2b0a))


### ✨ New Features

* flagSetMetadata in OFREP/ResolveAll, core refactors
([#1540](#1540))
([b49abf9](b49abf9))
* support yaml in blob, file, and http syncs
([#1522](#1522))
([76d673a](76d673a))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aepfli aepfli aepfli approved these changes

@austindrenski austindrenski austindrenski approved these changes

@toddbaert toddbaert toddbaert approved these changes

@warber warber Awaiting requested review from warber

Assignees
No one assigned
Labels
size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] inconsistent yaml support from file:// vs s3://
4 participants
@beeme1mr @aepfli @austindrenski @toddbaert