Skip to content

Conversation

JaydipGabani
Copy link
Contributor

@JaydipGabani JaydipGabani commented Aug 14, 2025

Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
@Copilot Copilot AI review requested due to automatic review settings August 14, 2025 19:29
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds status tracking functionality to external data providers in the Gatekeeper framework. The implementation adds status fields to Provider resources across multiple API versions to track provider pod status, errors, and operational state.

  • Adds comprehensive status structures including ProviderStatus, ProviderPodStatusStatus, and ProviderError types
  • Updates all API versions (v1alpha1, v1beta1, unversioned) with consistent status field implementations
  • Generates supporting deepcopy and conversion functions for the new status types

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
constraint/pkg/schema/yaml_constant.go Reformats multi-line descriptions in YAML schema definitions
constraint/pkg/apis/externaldata/v1beta1/provider_types.go Adds status types and fields to v1beta1 Provider API
constraint/pkg/apis/externaldata/v1beta1/zz_generated.deepcopy.go Generated deepcopy methods for new v1beta1 status types
constraint/pkg/apis/externaldata/v1beta1/zz_generated.conversion.go Generated conversion functions between v1beta1 and unversioned status types
constraint/pkg/apis/externaldata/v1alpha1/provider_types.go Adds status types and fields to v1alpha1 Provider API
constraint/pkg/apis/externaldata/v1alpha1/zz_generated.deepcopy.go Generated deepcopy methods for new v1alpha1 status types
constraint/pkg/apis/externaldata/v1alpha1/zz_generated.conversion.go Generated conversion functions between v1alpha1 and unversioned status types
constraint/pkg/apis/externaldata/unversioned/provider_types.go Adds status types and fields to unversioned Provider API
constraint/pkg/apis/externaldata/unversioned/zz_generated.deepcopy.go Generated deepcopy methods for new unversioned status types
constraint/deploy/crds.yaml Updates CRD definitions with status field schemas
constraint/config/crds/externaldata.gatekeeper.sh_providers.yaml Updates CRD configuration with status field schemas

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.73%. Comparing base (76869f8) to head (b4ad9bd).
⚠️ Report is 114 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #598       +/-   ##
===========================================
- Coverage   54.68%   42.73%   -11.96%     
===========================================
  Files          71       97       +26     
  Lines        5241     6515     +1274     
===========================================
- Hits         2866     2784       -82     
- Misses       2073     3432     +1359     
+ Partials      302      299        -3     
Flag Coverage Δ
unittests 42.73% <ø> (-11.96%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add status to providers.externaldata
2 participants