-
Notifications
You must be signed in to change notification settings - Fork 56
feat: adding status on external data #598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: adding status on external data #598
Conversation
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds status tracking functionality to external data providers in the Gatekeeper framework. The implementation adds status fields to Provider resources across multiple API versions to track provider pod status, errors, and operational state.
- Adds comprehensive status structures including ProviderStatus, ProviderPodStatusStatus, and ProviderError types
- Updates all API versions (v1alpha1, v1beta1, unversioned) with consistent status field implementations
- Generates supporting deepcopy and conversion functions for the new status types
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
constraint/pkg/schema/yaml_constant.go | Reformats multi-line descriptions in YAML schema definitions |
constraint/pkg/apis/externaldata/v1beta1/provider_types.go | Adds status types and fields to v1beta1 Provider API |
constraint/pkg/apis/externaldata/v1beta1/zz_generated.deepcopy.go | Generated deepcopy methods for new v1beta1 status types |
constraint/pkg/apis/externaldata/v1beta1/zz_generated.conversion.go | Generated conversion functions between v1beta1 and unversioned status types |
constraint/pkg/apis/externaldata/v1alpha1/provider_types.go | Adds status types and fields to v1alpha1 Provider API |
constraint/pkg/apis/externaldata/v1alpha1/zz_generated.deepcopy.go | Generated deepcopy methods for new v1alpha1 status types |
constraint/pkg/apis/externaldata/v1alpha1/zz_generated.conversion.go | Generated conversion functions between v1alpha1 and unversioned status types |
constraint/pkg/apis/externaldata/unversioned/provider_types.go | Adds status types and fields to unversioned Provider API |
constraint/pkg/apis/externaldata/unversioned/zz_generated.deepcopy.go | Generated deepcopy methods for new unversioned status types |
constraint/deploy/crds.yaml | Updates CRD definitions with status field schemas |
constraint/config/crds/externaldata.gatekeeper.sh_providers.yaml | Updates CRD configuration with status field schemas |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #598 +/- ##
===========================================
- Coverage 54.68% 42.73% -11.96%
===========================================
Files 71 97 +26
Lines 5241 6515 +1274
===========================================
- Hits 2866 2784 -82
- Misses 2073 3432 +1359
+ Partials 302 299 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
e5a452f
to
e90542d
Compare
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
Fixes open-policy-agent/gatekeeper#2917
Gatekeeper counter part - open-policy-agent/gatekeeper#4115