Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update GitHub actions #619

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: update GitHub actions #619

wants to merge 1 commit into from

Conversation

ryjones
Copy link

@ryjones ryjones commented Jan 8, 2025

The actions upload-artifact@v3 and download-artifact@v3 have been deprecated.

Fixes #618

fixes #618

Signed-off-by: Ry Jones <ry@linux.com>
@SWilson4
Copy link
Member

SWilson4 commented Jan 9, 2025

Man, that's a lot of CI failures. Even CircleCI is failing, so it's not related to this PR. @baentsch looks like it's OpenSSL-related?

@baentsch
Copy link
Member

baentsch commented Jan 9, 2025

looks like it's OpenSSL-related?

(Some) may well be -- the time is getting closer that standard PQC is landing in openssl, so clashes with oqsprovider are expected (one reason for my suggestion to no longer support standardized algorithms)-- but only with "master", not older releases.

When I'm looking at one of those, the error occurs exactly when the code of this PR gets used:

grafik

So it seems, more changes are required to make this PR pass CI.

@ryjones
Copy link
Author

ryjones commented Jan 13, 2025

it looks like there is a fix so I need to look into it more.

@SWilson4
Copy link
Member

it looks like there is a fix so I need to look into it more.

Thanks for digging into it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OQS Provider uses soon to be disabled version of GitHub actions.
3 participants