Release 1.5.10 #293
Release 1.5.10 #293
Conversation
…n users and roles
Add check for original in UpdateOne Remove legacy userid in hasAuthorization
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 493645 | Triggered | Generic High Entropy Secret | c02212e | test/docker-compose.yml | View secret |
| 431268 | Triggered | Generic Private Key | 47a8be7 | openflow.env | View secret |
| 5877162 | Triggered | Generic High Entropy Secret | 602e0ec | OpenFlow/src/OAuthProvider.ts | View secret |
| 493644 | Triggered | Generic Private Key | c02212e | test/docker-compose.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
| throw new Error("Empty token is not valid"); | ||
| } | ||
| if (jwt.indexOf(" ") > 1 && (jwt.toLowerCase().startsWith("bearer") || jwt.toLowerCase().startsWith("jwt"))) { |
Check failure
Code scanning / CodeQL
Type confusion through parameter tampering Critical
| if (jwt.indexOf(" ") > 1 && (jwt.toLowerCase().startsWith("bearer") || jwt.toLowerCase().startsWith("jwt"))) { | ||
| const token = jwt.split(" ")[1].toString(); | ||
| jwt = token; | ||
| } else if(jwt.indexOf(" ") > 1 && jwt.toLowerCase().startsWith("basic")) { |
Check failure
Code scanning / CodeQL
Type confusion through parameter tampering Critical
| // Valid SAML token ? | ||
| if (tuser == null && user == null) { | ||
| try { | ||
| if (jwt.indexOf("saml") > 0) { // <saml2:Assertion |
Check failure
Code scanning / CodeQL
Type confusion through parameter tampering Critical
| app.post("/AddTokenRequest", LoginProvider.post_AddTokenRequest.bind(this)); | ||
| app.get("/GetTokenRequest", LoginProvider.get_GetTokenRequest.bind(this)); | ||
| app.get("/login", LoginProvider.get_login.bind(this)); | ||
| app.get("/login/*", LoginProvider.get_login2.bind(this)); |
Check failure
Code scanning / CodeQL
Missing rate limiting High
| app.post("/AddTokenRequest", LoginProvider.post_AddTokenRequest.bind(this)); | ||
| app.get("/GetTokenRequest", LoginProvider.get_GetTokenRequest.bind(this)); | ||
| app.get("/login", LoginProvider.get_login.bind(this)); | ||
| app.get("/login/*", LoginProvider.get_login2.bind(this)); | ||
| app.get("/Login", LoginProvider.get_login.bind(this)); |
Check failure
Code scanning / CodeQL
Missing rate limiting High
| app.get("/login/*", LoginProvider.get_login2.bind(this)); | ||
| app.get("/Login", LoginProvider.get_login.bind(this)); | ||
| app.get("/Login/*", LoginProvider.get_login2.bind(this)); | ||
| app.get("/auth/signinwin/main", LoginProvider.get_login3.bind(this)); |
Check failure
Code scanning / CodeQL
Missing rate limiting High
| Logger.instanse.debug("return PassiveLogin.html", span, {cls: "LoginProvider", func: "getlogin"}); | ||
| const localfile = path.join(__dirname, 'public', requestedfile); | ||
| const webappfile = path.join(WebServer.webapp_file_path, requestedfile); | ||
| if(fs.existsSync(webappfile)) { |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
| const webappfile = path.join(WebServer.webapp_file_path, requestedfile); | ||
| if(fs.existsSync(webappfile)) { | ||
| // console.log("serve webapp " + webappfile); | ||
| res.sendFile(webappfile); |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
| if(fs.existsSync(webappfile)) { | ||
| // console.log("serve webapp " + webappfile); | ||
| res.sendFile(webappfile); | ||
| } else if(fs.existsSync(localfile)) { |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
| res.sendFile(webappfile); | ||
| } else if(fs.existsSync(localfile)) { | ||
| // console.log("serve file " + localfile); | ||
| res.sendFile(localfile); |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
No description provided.