Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generating protobuf at container build time #1384

Closed
wants to merge 5 commits into from

Conversation

fsolleza
Copy link
Contributor

Changes

Problem:

Small changes to protobuf require extensive tooling to generate protobuf using make generate-protobuf. ide-gen-proto.sh shows how some service's protobuf might be generated.

Four services' generated protobuf code were moved to container build time. This doesn't replace make generate-protobuf which is still useful when understanding the protobuf code outside of build time. It makes make start and friends friendlier to small changes to pb/demo.proto.

The four services affected are:

  1. accountingservice
  2. checkoutservice
  3. productcatalogservice
  4. currencyservice

Solution is discussed in-depth in #1374

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@fsolleza fsolleza requested a review from a team February 16, 2024 14:44
Copy link

linux-foundation-easycla bot commented Feb 16, 2024

CLA Missing ID CLA Not Signed

@puckpuck
Copy link
Contributor

@fsolleza please sign the CLA when you get a chance

@fsolleza
Copy link
Contributor Author

Hmm - I'm unfamiliar with this process but I've signed the CLA (or so I think).

@austinlparker
Copy link
Member

Seems like there's still an issue with the CLA (see #1384 (comment)) -- is the email associated with the commits different than the one that you signed the CLA with? You may need to squash your commits locally and force push the branch to resolve this.

@fsolleza
Copy link
Contributor Author

Ok, I'm gonna retry with another pull request with hopefully the correct email address. It's small enough to easily just recreate from a clean branch tracking upstream.

@fsolleza fsolleza closed this Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants