Generating protobuf at container build time #1384
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Problem:
Small changes to protobuf require extensive tooling to generate protobuf using
make generate-protobuf
.ide-gen-proto.sh
shows how some service's protobuf might be generated.Four services' generated protobuf code were moved to container build time. This doesn't replace
make generate-protobuf
which is still useful when understanding the protobuf code outside of build time. It makesmake start
and friends friendlier to small changes topb/demo.proto
.The four services affected are:
Solution is discussed in-depth in #1374
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.md
updated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.