Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build protobuf in dockerfile for all services #1386

Merged
merged 6 commits into from
Mar 7, 2024

Conversation

fsolleza
Copy link
Contributor

Changes

Problem: Small changes to protobuf require extensive tooling to generate protobuf using make generate-protobuf. ide-gen-proto.sh shows how some service's protobuf might be generated.

Four services' generated protobuf code were moved to container build time. This doesn't replace make generate-protobuf which is still useful when understanding the protobuf code outside of build time. It makes make start and friends friendlier to small changes to pb/demo.proto.

The four services affected are:

  • accountingservice
  • checkoutservice
  • productcatalogservice
  • currencyservice

This was discussed here: #1374

  • This is a resubmit of another PR where the email address (and resulting CLA) was messed up for some reason.

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

…ice, currencyservice, and productcatalogservice
@fsolleza fsolleza requested a review from a team February 18, 2024 09:17
@fsolleza
Copy link
Contributor Author

fsolleza commented Feb 19, 2024

I'm not exactly sure why currencyservice is failing the check?

Error: buildx failed with: ERROR: failed to solve: failed to compute cache key: failed to calculate checksum of ref cewwk3g7np5pflqnggalica0g::oepmw7nh6irdnl07gnw8ofc9c: failed to walk /tmp/buildkit-mount1551154311/src: lstat /tmp/buildkit-mount1551154311/src: no such file or directory

Happy to fix if pointed the right way.

Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 28, 2024
@puckpuck puckpuck removed the Stale label Mar 1, 2024
@austinlparker
Copy link
Member

Interesting. Looks like it can't find the source directory in builder somehow, but it works locally. Gonna poke at it a bit.

@austinlparker
Copy link
Member

Oh, duh. Ok, the problem is the changes you made to the context path in the docker compose file.

@austinlparker
Copy link
Member

I think it should work now. You changed the build context in the compose file, but not in the GitHub workflow, so the docker context was being set to ./src/currencyservice rather than ./

@austinlparker austinlparker merged commit 0c80094 into open-telemetry:main Mar 7, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants