-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build protobuf in dockerfile for all services #1386
Conversation
…ice, currencyservice, and productcatalogservice
I'm not exactly sure why currencyservice is failing the check? Error: buildx failed with: ERROR: failed to solve: failed to compute cache key: failed to calculate checksum of ref cewwk3g7np5pflqnggalica0g::oepmw7nh6irdnl07gnw8ofc9c: failed to walk /tmp/buildkit-mount1551154311/src: lstat /tmp/buildkit-mount1551154311/src: no such file or directory Happy to fix if pointed the right way. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Interesting. Looks like it can't find the source directory in builder somehow, but it works locally. Gonna poke at it a bit. |
Oh, duh. Ok, the problem is the changes you made to the context path in the docker compose file. |
I think it should work now. You changed the build context in the compose file, but not in the GitHub workflow, so the docker context was being set to |
Changes
Problem: Small changes to protobuf require extensive tooling to generate protobuf using
make generate-protobuf
.ide-gen-proto.sh
shows how some service's protobuf might be generated.Four services' generated protobuf code were moved to container build time. This doesn't replace
make generate-protobuf
which is still useful when understanding the protobuf code outside of build time. It makesmake start
and friends friendlier to small changes topb/demo.proto
.The four services affected are:
This was discussed here: #1374
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.md
updated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.