Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[paymentservice] Adds otel logging support #1481

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/paymentservice/charge.js
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,17 @@ module.exports.charge = async request => {
span.end();

const { units, nanos, currencyCode } = request.amount;
logger.info({transactionId, cardType, lastFourDigits, amount: { units, nanos, currencyCode }}, "Transaction complete.");
logger.emit({
severityNumber: SeverityNumber.INFO,
severityText: "INFO",
body: "Transaction complete.",
attributes: {
transactionId,
cardType,
lastFourDigits,
amount: { units, nanos, currencyCode },
},
});
transactionsCounter.add(1, {"app.payment.currency": currencyCode})
return { transactionId }
}
104 changes: 64 additions & 40 deletions src/paymentservice/index.js
Original file line number Diff line number Diff line change
@@ -1,59 +1,83 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0
const grpc = require('@grpc/grpc-js')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kimbohlovette could you keep the same indentation we had before?

It would make our life as reviewers easier

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

const protoLoader = require('@grpc/proto-loader')
const health = require('grpc-js-health-check')
const opentelemetry = require('@opentelemetry/api')
const grpc = require("@grpc/grpc-js");
const protoLoader = require("@grpc/proto-loader");
const health = require("grpc-js-health-check");
const opentelemetry = require("@opentelemetry/api");
const { SeverityNumber } = require("@opentelemetry/api-logs");

const charge = require('./charge')
const logger = require('./logger')
const charge = require("./charge");
const logger = require("./logger");

async function chargeServiceHandler(call, callback) {
const span = opentelemetry.trace.getActiveSpan();
const span = opentelemetry.trace.getActiveSpan();

try {
const amount = call.request.amount
span.setAttributes({
'app.payment.amount': parseFloat(`${amount.units}.${amount.nanos}`)
})
logger.info({ request: call.request }, "Charge request received.")
try {
const amount = call.request.amount;
span.setAttributes({
"app.payment.amount": parseFloat(`${amount.units}.${amount.nanos}`),
});
logger.emit({
severityNumber: SeverityNumber.INFO,
severityText: "INFO",
body: "Charge request received.",
attributes: { request: call.request },
});

const response = await charge.charge(call.request)
callback(null, response)
const response = await charge.charge(call.request);
callback(null, response);
} catch (err) {
logger.emit({
severityNumber: SeverityNumber.WARN,
severityText: "ERROR",
body: "Charge request failed.",
attributes: { request: call.request },
});

} catch (err) {
logger.warn({ err })
span.recordException(err);
span.setStatus({ code: opentelemetry.SpanStatusCode.ERROR });

span.recordException(err)
span.setStatus({ code: opentelemetry.SpanStatusCode.ERROR })

callback(err)
}
callback(err);
}
}

async function closeGracefully(signal) {
server.forceShutdown()
process.kill(process.pid, signal)
server.forceShutdown();
process.kill(process.pid, signal);
}

const otelDemoPackage = grpc.loadPackageDefinition(protoLoader.loadSync('demo.proto'))
const server = new grpc.Server()
const otelDemoPackage = grpc.loadPackageDefinition(
protoLoader.loadSync("demo.proto")
);
const server = new grpc.Server();

server.addService(health.service, new health.Implementation({
'': health.servingStatus.SERVING
}))
server.addService(
health.service,
new health.Implementation({
"": health.servingStatus.SERVING,
})
);

server.addService(otelDemoPackage.oteldemo.PaymentService.service, { charge: chargeServiceHandler })
server.addService(otelDemoPackage.oteldemo.PaymentService.service, {
charge: chargeServiceHandler,
});

server.bindAsync(`0.0.0.0:${process.env['PAYMENT_SERVICE_PORT']}`, grpc.ServerCredentials.createInsecure(), (err, port) => {
if (err) {
return logger.error({ err })
}
server.bindAsync(
`0.0.0.0:${process.env["PAYMENT_SERVICE_PORT"]}`,
grpc.ServerCredentials.createInsecure(),
(err, port) => {
if (err) {
return logger.error({ err });
}

logger.info(`PaymentService gRPC server started on port ${port}`)
server.start()
}
)
logger.emit({
severityNumber: SeverityNumber.INFO,
severityText: "INFO",
body: `PaymentService gRPC server started on port ${port}.`,
});
server.start();
}
);

process.once('SIGINT', closeGracefully)
process.once('SIGTERM', closeGracefully)
process.once('SIGINT', closeGracefully);
process.once('SIGTERM', closeGracefully);
14 changes: 12 additions & 2 deletions src/paymentservice/logger.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,16 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0
const {
LoggerProvider,
SimpleLogRecordProcessor,
ConsoleLogRecordExporter,
} = require("@opentelemetry/sdk-logs");
import { logs } from "@opentelemetry/api-logs";

const pino = require('pino');
const loggerProvider = new LoggerProvider();
loggerProvider.addLogRecordProcessor(
new SimpleLogRecordProcessor(new ConsoleLogRecordExporter())
);
logs.setGlobalLoggerProvider(loggerProvider);

module.exports = pino();
module.exports = logs.getLogger("paymentservice", "1.0.0");
81 changes: 46 additions & 35 deletions src/paymentservice/opentelemetry.js
Original file line number Diff line number Diff line change
@@ -1,41 +1,52 @@
// Copyright The OpenTelemetry Authors
// SPDX-License-Identifier: Apache-2.0

const opentelemetry = require("@opentelemetry/sdk-node")
const {getNodeAutoInstrumentations} = require("@opentelemetry/auto-instrumentations-node")
const {OTLPTraceExporter} = require('@opentelemetry/exporter-trace-otlp-grpc')
const {OTLPMetricExporter} = require('@opentelemetry/exporter-metrics-otlp-grpc')
const {PeriodicExportingMetricReader} = require('@opentelemetry/sdk-metrics')
const {alibabaCloudEcsDetector} = require('@opentelemetry/resource-detector-alibaba-cloud')
const {awsEc2Detector, awsEksDetector} = require('@opentelemetry/resource-detector-aws')
const {containerDetector} = require('@opentelemetry/resource-detector-container')
const {gcpDetector} = require('@opentelemetry/resource-detector-gcp')
const {envDetector, hostDetector, osDetector, processDetector} = require('@opentelemetry/resources')
const { NodeSDK, tracing } = require("@opentelemetry/sdk-node");

const sdk = new opentelemetry.NodeSDK({
traceExporter: new OTLPTraceExporter(),
instrumentations: [
getNodeAutoInstrumentations({
// only instrument fs if it is part of another trace
'@opentelemetry/instrumentation-fs': {
requireParentSpan: true,
},
})
],
metricReader: new PeriodicExportingMetricReader({
exporter: new OTLPMetricExporter()
}),
resourceDetectors: [
containerDetector,
envDetector,
hostDetector,
osDetector,
processDetector,
alibabaCloudEcsDetector,
awsEksDetector,
awsEc2Detector,
gcpDetector
],
})
const {
OTLPTraceExporter,
} = require('@opentelemetry/exporter-trace-otlp-grpc');
const {
OTLPMetricExporter,
} = require('@opentelemetry/exporter-metrics-otlp-grpc');
const { PeriodicExportingMetricReader } = require('@opentelemetry/sdk-metrics');
const {
alibabaCloudEcsDetector,
} = require('@opentelemetry/resource-detector-alibaba-cloud');
const {
awsEc2Detector,
awsEksDetector,
} = require('@opentelemetry/resource-detector-aws');
const {
containerDetector,
} = require('@opentelemetry/resource-detector-container');
const { gcpDetector } = require('@opentelemetry/resource-detector-gcp');
const {
envDetector,
hostDetector,
osDetector,
processDetector,
} = require("@opentelemetry/resources");

const sdk = new NodeSDK({
traceExporter: new OTLPTraceExporter(),
spanProcessor: new tracing.SimpleSpanProcessor(
new tracing.ConsoleSpanExporter()
),
metricReader: new PeriodicExportingMetricReader({
exporter: new OTLPMetricExporter(),
}),
resourceDetectors: [
containerDetector,
envDetector,
hostDetector,
osDetector,
processDetector,
alibabaCloudEcsDetector,
awsEksDetector,
awsEc2Detector,
gcpDetector,
],
});

sdk.start();
Loading
Loading