Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] frontend: update Dockerfile to reduce final image size by 15% #2017

Merged

Conversation

macno
Copy link
Contributor

@macno macno commented Feb 10, 2025

Changes

Currently, all the dev dependencies are included in the final image.

Reworking the first two stages, we can reduce the final image by ~15%

╰─➤  docker images otel-demo-frontend
REPOSITORY           TAG       IMAGE ID       CREATED          SIZE
otel-demo-frontend   fix       0a53d5f0fdcc   14 minutes ago   707MB
otel-demo-frontend   orig      a863b800e2ab   19 minutes ago   823MB

Merge Requirements

For new features contributions, please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@macno macno requested a review from a team as a code owner February 10, 2025 13:26
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that @macno!

@julianocosta89
Copy link
Member

Hey @macno would you be able to take a look at this again?
We got a PR merged that changed a couple of things

@julianocosta89 julianocosta89 self-requested a review February 12, 2025 09:23
@macno
Copy link
Contributor Author

macno commented Feb 12, 2025

Hey @macno would you be able to take a look at this again? We got a PR merged that changed a couple of things

on it

@macno macno force-pushed the improve-frontend-dockerfile branch from 88d8373 to eca6998 Compare February 12, 2025 10:15
@julianocosta89 julianocosta89 merged commit fa06ec0 into open-telemetry:main Feb 12, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants