Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create featureflags table and populate it #1029

Closed

Conversation

fvlankvelt
Copy link

@fvlankvelt fvlankvelt commented Feb 5, 2024

The postgres database used by the featureflagservice is not initialized / migrated any more by ecto. This PR tries to mimic the behavior of the docker-compose.yml of the opentelemetry-demo project.

@fvlankvelt fvlankvelt requested a review from puckpuck as a code owner February 5, 2024 12:26
@fvlankvelt fvlankvelt requested a review from a team February 5, 2024 12:26
Copy link

linux-foundation-easycla bot commented Feb 5, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@fvlankvelt fvlankvelt force-pushed the create-ffs-tables-on-startup branch from 5cc0e51 to c6ee47a Compare February 5, 2024 13:04
@puckpuck
Copy link
Contributor

puckpuck commented Feb 5, 2024

This is fixed in the current build on main of the demo, where the table is created as part of the postgres image. When that version gets released we will update this Helm chart to work with it.

@puckpuck
Copy link
Contributor

This PR is going to be addressed as part of #1026

@puckpuck puckpuck closed this Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants