-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[demo] - load-generator Adapt OpenFeature OFREP instead of IN_PROCESS #1563
base: main
Are you sure you want to change the base?
[demo] - load-generator Adapt OpenFeature OFREP instead of IN_PROCESS #1563
Conversation
OpenFeature supports multiple different modes. The newest implementation relies on threads and other python internal, which seem to be monkeypatched by locust. Due to this, the IN_PROCESS mode is not working properly anymore and is causing issues. Instead we suggest to switch to the OFREP (OpenFeature Remote Evaluation Protocol) for this usecase. This is a simple http call which will return all evaluate flags, and will regularly poll for changes. Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
hey @aepfli, I've tried to push to your branch, but got permission denied. You need to:
|
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
cc6390f
to
0eb924f
Compare
thank you for this great explanation - did all the steps and committed all changes Thank you! |
@puckpuck this one should be good to go, should we release 2.0.2? |
Because this needs a new Load Generator image, we need to make this as part of a Demo 2.0.2 release. |
…for-loadgenerator
yes, pls update |
@JaredTan95 @puckpuck i increased the appVersion ;) thank you |
@aepfli you need to generate the examples again 😢 |
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
oh my bad - rookie mistake, fixed and pushed |
Demo 2.0.2 released, this one should be good to go! |
is there anything i can do to fix this build? |
@aepfli it seems flagd-ui is failing to start due to lack of memory. This has nothing to do with your PR, but we may need to merge another PR before yours, or add the changes from #1571 in here. Basically we just need to increase falgd-ui memory to 100M: https://github.com/open-telemetry/opentelemetry-demo/pull/2120/files. @open-telemetry/helm-approvers what would be the best approach here? |
OpenFeature supports multiple different modes.
The newest implementation relies on threads and other python internal, which seem to be monkeypatched by locust.
Due to this, the IN_PROCESS mode is not working properly anymore and is causing issues.
Instead we suggest to switch to the OFREP (OpenFeature Remote Evaluation Protocol) for this usecase. This is a simple http call which will return all evaluate flags, and will regularly poll for changes.
This pr contains the helm changes matching open-telemetry/opentelemetry-demo#2114 - but my helm knowledge is limited, please let me know, if i am missing anything here.