Skip to content

Commit

Permalink
test: Add logger to Apprasials for Rails 6.1, 7.0
Browse files Browse the repository at this point in the history
For action_mailer, action_pack, action_view, delayed_job, and rails
the tests started failing with an uninitialized constant error:
  /opt/hostedtoolcache/Ruby/3.3.6/x64/lib/ruby/gems/3.3.0/gems/
activesupport-6.1.7.10/lib/active_support/logger_thread_safe_level.rb
:16:in `<module:LoggerThreadSafeLevel>': uninitialized constant
ActiveSupport::LoggerThreadSafeLevel::Logger (NameError)

      Logger::Severity.constants.each do |severity|
      ^^^^^^

Adding the logger library explicitly to the Appraisal resolves the
error.
  • Loading branch information
kaylareopelle committed Jan 16, 2025
1 parent 07c9cf4 commit 8722b6a
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 0 deletions.
1 change: 1 addition & 0 deletions instrumentation/action_mailer/Appraisals
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
%w[6.1.0 7.0.0 7.1.0].each do |version|
appraise "action_mailer-#{version}" do
gem 'rails', "~> #{version}"
gem 'logger'
end
end

Expand Down
1 change: 1 addition & 0 deletions instrumentation/action_pack/Appraisals
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
%w[6.1.0 7.0.0 7.1.0].each do |version|
appraise "rails-#{version}" do
gem 'rails', "~> #{version}"
gem 'logger'
end
end

Expand Down
1 change: 1 addition & 0 deletions instrumentation/action_view/Appraisals
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
%w[6.1.0 7.0.0 7.1.0].each do |version|
appraise "action_view-#{version}" do
gem 'rails', "~> #{version}"
gem 'logger'
end
end

Expand Down
1 change: 1 addition & 0 deletions instrumentation/delayed_job/Appraisals
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
appraise "delayed_job_4.1-activejob-#{version}" do
gem 'delayed_job', '~> 4.1'
gem 'activejob', "~> #{version}"
gem 'logger'
end
end

Expand Down
1 change: 1 addition & 0 deletions instrumentation/rails/Appraisals
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
%w[6.1.0 7.0.0 7.1.0].each do |version|
appraise "rails-#{version}" do
gem 'rails', "~> #{version}"
gem 'logger'
end
end

Expand Down

0 comments on commit 8722b6a

Please sign in to comment.